Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump supported Ruby version to >= 2.1.0 #6220

Merged
merged 1 commit into from Jul 25, 2017

Conversation

@ashmaroli
Copy link
Member

ashmaroli commented Jul 12, 2017

I realized from #6216 that our runtime_dependency Liquid 4.0 has already dropped support for Ruby Versions older than 2.1.0. So there's no point in not following suit ourselves.

@DirtyF
DirtyF approved these changes Jul 12, 2017
@ghost
ghost approved these changes Jul 12, 2017
Copy link
Member

parkr left a comment

We cannot do this until Jekyll 4.0. We can only implicitly drop support by dropping Travis CI targets. Many users still use Ruby 2.0 and if they want to, we can't stop them in Jekyll 3.x.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Jul 13, 2017

This is a major breaking change and will have to wait for v4.0 which we have no plans for at the moment. Thanks!

@parkr parkr closed this Jul 13, 2017
@parkr

This comment has been minimized.

Copy link
Member

parkr commented Jul 13, 2017

Ah, I see, Liquid has already done this.

@parkr parkr reopened this Jul 13, 2017
@parkr parkr added this to the 3.6 milestone Jul 17, 2017
@DirtyF DirtyF added the dependency label Jul 18, 2017
@parkr
parkr approved these changes Jul 25, 2017
@parkr

This comment has been minimized.

Copy link
Member

parkr commented Jul 25, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 96724af into jekyll:master Jul 25, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jekyllbot added a commit that referenced this pull request Jul 25, 2017
@ashmaroli ashmaroli deleted the ashmaroli:bump-min-ruby-version branch Jul 31, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.