Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader#read_directories: guard against an entry not being a directory #6226

Merged
merged 2 commits into from Jul 25, 2017

Conversation

@parkr
Copy link
Member

parkr commented Jul 17, 2017

Fixes the following error:

Not a directory @ dir_chdir - /home/jekyll/src/_posts

/cc @jekyll/stability

@parkr parkr assigned DirtyF and pathawks and unassigned parkr and jekyllbot Jul 17, 2017
@DirtyF
DirtyF approved these changes Jul 17, 2017
Copy link
Member

DirtyF left a comment

👍 once the formatting error is fixed:

lib/jekyll/reader.rb:41:1: C: Layout/TrailingWhitespace: Trailing whitespace detected.
Copy link
Member

SuriyaaKudoIsc left a comment

👍 LGTM

@parkr

This comment has been minimized.

Copy link
Member Author

parkr commented Jul 25, 2017

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 188bc71 into master Jul 25, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jekyllbot jekyllbot added bug fix labels Jul 25, 2017
@jekyllbot jekyllbot deleted the read-directories-should-require-directory branch Jul 25, 2017
jekyllbot added a commit that referenced this pull request Jul 25, 2017
@parkr parkr mentioned this pull request Aug 12, 2017
6 of 6 tasks complete
parkr added a commit that referenced this pull request Aug 12, 2017
…stable
parkr added a commit that referenced this pull request Aug 12, 2017
Backport #6226 for v3.5.x: Reader#read_directories: guard against an entry not being a directory
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.