New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecator.rb: fix typo for --serve command #6229

Merged
merged 5 commits into from Jul 18, 2017

Conversation

Projects
None yet
5 participants
@ashmaroli
Member

ashmaroli commented Jul 18, 2017

Mostly a personal preference, not sure how it affects overall performance

/cc @pathawks

ashmaroli added some commits Jul 18, 2017

remove duplicate topic label
The first warning is short enough such that it wont wrap to the next line.
Hence the subsequent message does not need a topic label.
@oe

eh, fine by me. it's basically just a matter of personal preference since i'm pretty sure we use both styles within the codebase already

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jul 18, 2017

Member

I don't mind, but it might be worth not making changes that would muddy git blame

Member

pathawks commented Jul 18, 2017

I don't mind, but it might be worth not making changes that would muddy git blame

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jul 18, 2017

Member

hmm, okay.. I'll use this PR to correct the typo and remove just the \n at towards the end of the file then.. k?

Member

ashmaroli commented Jul 18, 2017

hmm, okay.. I'll use this PR to correct the typo and remove just the \n at towards the end of the file then.. k?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jul 18, 2017

Member

Since jekyllbot doesn't squash and merge, I'll manually rebase once the new diff is approved..

Member

ashmaroli commented Jul 18, 2017

Since jekyllbot doesn't squash and merge, I'll manually rebase once the new diff is approved..

@pathawks

Looks good after squash 👍

@DirtyF DirtyF changed the title from Optimize whitespace in deprecator.rb to deprecator.rb: fix typo for --serve command Jul 18, 2017

@DirtyF

DirtyF approved these changes Jul 18, 2017

Good catch @ashmaroli 👍

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jul 18, 2017

Member

@jekyllbot: merge +bug

Member

DirtyF commented Jul 18, 2017

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit c0c1185 into jekyll:master Jul 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Jul 18, 2017

jekyllbot added a commit that referenced this pull request Jul 18, 2017

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jul 18, 2017

Member

Well I'll be a....... JekyllBot does squash and merge.. Cool!
Thanks Frank 😃

Member

ashmaroli commented Jul 18, 2017

Well I'll be a....... JekyllBot does squash and merge.. Cool!
Thanks Frank 😃

@ashmaroli ashmaroli deleted the ashmaroli:Deprecator-whitespace branch Jul 18, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jul 18, 2017

Member

I forgot about that 😜👍🏼

Member

pathawks commented Jul 18, 2017

I forgot about that 😜👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment