New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix links to issues in History.markdown #6255

Merged
merged 1 commit into from Jul 30, 2017

Conversation

Projects
None yet
5 participants
@DirtyF
Member

DirtyF commented Jul 29, 2017

fix #6254

/cc @jekyll/documentation

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jul 29, 2017

Member

@DirtyF I just realized, Liquid doesn't care about backticks..
The solution here is to remove / replace the {% raw %} tag or even try enclosing it in a raw block.. but dunno if that's gonna work..

Update: Tried it locally.. The following worked:

`{% raw %}{% raw %}{% endraw %}`
Member

ashmaroli commented Jul 29, 2017

@DirtyF I just realized, Liquid doesn't care about backticks..
The solution here is to remove / replace the {% raw %} tag or even try enclosing it in a raw block.. but dunno if that's gonna work..

Update: Tried it locally.. The following worked:

`{% raw %}{% raw %}{% endraw %}`
@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jul 29, 2017

Member

@ashmaroli Thanks for your concern, but I did test this change locally before committing and it worked as expected.

It's because the source file History.markdown goes through a liquid_escape function when the rake task generates the corresponding output file in the docs.

Member

DirtyF commented Jul 29, 2017

@ashmaroli Thanks for your concern, but I did test this change locally before committing and it worked as expected.

It's because the source file History.markdown goes through a liquid_escape function when the rake task generates the corresponding output file in the docs.

@DirtyF DirtyF changed the title from Docs: add missing backticks in History to Docs: fix links to issues in History.markdown Jul 29, 2017

@parkr

parkr approved these changes Jul 30, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 30, 2017

Member

@jekyllbot: merge +docs

Member

parkr commented Jul 30, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 12832af into jekyll:master Jul 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jul 30, 2017

@DirtyF DirtyF deleted the DirtyF:docs/fix-6254 branch Jul 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment