New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing url in collection elements clarified #6264

Merged
merged 4 commits into from Aug 9, 2017

Conversation

Projects
None yet
5 participants
@lymaconsulting
Contributor

lymaconsulting commented Aug 3, 2017

I was unable to use custom links in collections until i dug up this bit in the source code, and this a PR demonstrating a more clear explanation of the linked behavior in the source code. great project guys! lemme know what yall think of the contribution.

@Crunch09

This comment has been minimized.

Show comment
Hide comment
@Crunch09

Crunch09 Aug 3, 2017

Member

👍 Thanks for your contribution! This behavior has been in the code since #3383, so it's time to update the documentation 🙂

Member

Crunch09 commented Aug 3, 2017

👍 Thanks for your contribution! This behavior has been in the code since #3383, so it's time to update the documentation 🙂

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF
Member

DirtyF commented Aug 3, 2017

@DirtyF

DirtyF approved these changes Aug 3, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Aug 3, 2017

Member

@lymaconsulting thanks for digging that up, your help is greatly appreciated!

Member

DirtyF commented Aug 3, 2017

@lymaconsulting thanks for digging that up, your help is greatly appreciated!

Show outdated Hide outdated docs/_docs/collections.md

@parkr parkr added the documentation label Aug 4, 2017

@lymaconsulting

This comment has been minimized.

Show comment
Hide comment
@lymaconsulting

lymaconsulting Aug 4, 2017

Contributor

maybe we can work on the wording collaboratively if this doesnt work? i.e. please let me know how to word this?

Contributor

lymaconsulting commented Aug 4, 2017

maybe we can work on the wording collaboratively if this doesnt work? i.e. please let me know how to word this?

@lymaconsulting

This comment has been minimized.

Show comment
Hide comment
@lymaconsulting

lymaconsulting Aug 9, 2017

Contributor

@parkr hows it look?

Contributor

lymaconsulting commented Aug 9, 2017

@parkr hows it look?

@parkr

parkr approved these changes Aug 9, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 9, 2017

Member

Well done, thank you!

@jekyllbot: merge +site

Member

parkr commented Aug 9, 2017

Well done, thank you!

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit bc962fe into jekyll:master Aug 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Aug 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment