New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: `site.url` behavior on development and production environments #6270

Merged
merged 4 commits into from Aug 30, 2017

Conversation

Projects
None yet
5 participants
@white-gecko
Contributor

white-gecko commented Aug 4, 2017

Add some more information regarding the special behavior of site.url when using jekyll serve in the site.[CONFIGURATION_DATA] section. See also: https://jekyllrb.com/news/#3-siteurl-is-set-by-the-development-server.
This brought up some confusion: mmistakes/hpstr-jekyll-theme#167 and white-gecko/jekyll-rdf#102

Update variables.md site.[CONFIGURATION_DATA]
Add some more information regarding the special behavior of `site.url` when using `jekyll serve` in the `site.[CONFIGURATION_DATA]` section. See also: https://jekyllrb.com/news/#3-siteurl-is-set-by-the-development-server.
This brought up some confusion: mmistakes/hpstr-jekyll-theme#167 and white-gecko/jekyll-rdf#102
@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli
Member

ashmaroli commented Aug 4, 2017

@DirtyF

👍 on the addition. Realizing there's no site.urlvariable explanation on this page. Perhaps your PR could also take care of that?

Show outdated Hide outdated docs/_docs/variables.md

@DirtyF DirtyF added the documentation label Aug 4, 2017

@white-gecko

This comment has been minimized.

Show comment
Hide comment
@white-gecko

white-gecko Aug 18, 2017

Contributor

I've just created a second suggestion for the change.

Contributor

white-gecko commented Aug 18, 2017

I've just created a second suggestion for the change.

@DirtyF

Just a minor comment, otherwise 👍

Show outdated Hide outdated docs/_docs/variables.md
@DirtyF

DirtyF approved these changes Aug 18, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Aug 18, 2017

Member

Anyone else from @jekyll/documentation care to review?

Member

DirtyF commented Aug 18, 2017

Anyone else from @jekyll/documentation care to review?

Show outdated Hide outdated docs/_docs/variables.md

@DirtyF DirtyF changed the title from Update variables.md site.[CONFIGURATION_DATA] to Docs: `site.url` behavior on development and production environments Aug 22, 2017

@white-gecko

This comment has been minimized.

Show comment
Hide comment
@white-gecko

white-gecko Aug 30, 2017

Contributor

@parkr can this be merged or do you want further changes?

Contributor

white-gecko commented Aug 30, 2017

@parkr can this be merged or do you want further changes?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Aug 30, 2017

Member

Let's :shipit:
@jekyllbot: merge +docs

Member

DirtyF commented Aug 30, 2017

Let's :shipit:
@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 06d1650 into jekyll:master Aug 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Aug 30, 2017

@white-gecko white-gecko deleted the white-gecko:patch-1 branch Aug 30, 2017

@tordans tordans referenced this pull request Jan 26, 2018

Closed

Jekyll 4.0 Wishlist #5307

@tordans tordans referenced this pull request Aug 21, 2018

Closed

Jekyll 4.0 Ideas #6948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment