Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Guard against type error in absolute url #6280
If a user sets an
Via #6185 and #6253 we normalize the
This PR calls an explicit
Code looks solid.
This kind of error is nice; it provides the user with the information that the url they provided is complete bogus – "whoops, gotta fix that!" It calls them to action in a way that suppressing this might not. Do you agree that we're losing value there?
@parkr see the bug report in jekyll/jekyll-feed#178. Given that it took some of Jekyll's top contributors 3+ weeks to determine the root cause of the opaque
An alternative approach would be a more descriptive error with page/post-level backtrace, but that's beyond what I'm able to invest right now.