Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Drop#key? so it can handle a nil argument #6281

Merged
merged 2 commits into from Aug 9, 2017

Conversation

@parkr
Copy link
Member

parkr commented Aug 8, 2017

In Liquid 4.0, Liquid::VariableLookup#evaulate checks input.key? when it's evaluating. If the key is nil, it throws the following error:

  Liquid Exception: nil is not a symbol nor a string in <template>

We should simply return false for Drop#key?(nil).

/cc @jekyll/stability

@jekyllbot jekyllbot assigned parkr and ghost Aug 8, 2017
@parkr parkr added the fix label Aug 8, 2017
@parkr parkr requested review from pathawks and Aug 8, 2017
@ghost
ghost approved these changes Aug 8, 2017
@parkr

This comment has been minimized.

Copy link
Member Author

parkr commented Aug 9, 2017

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit bd31986 into master Aug 9, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jekyllbot jekyllbot added bug fix labels Aug 9, 2017
@jekyllbot jekyllbot deleted the drop-key-types branch Aug 9, 2017
jekyllbot added a commit that referenced this pull request Aug 9, 2017
parkr added a commit that referenced this pull request Aug 10, 2017
parkr added a commit that referenced this pull request Aug 10, 2017
Merge pull request 6281
parkr added a commit that referenced this pull request Aug 10, 2017
Backport #6281 for v3.5.x: Fix Drop#key? so it can handle a nil argument
@parkr parkr mentioned this pull request Aug 10, 2017
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.