New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a quick test for DataReader #6284

Merged
merged 2 commits into from Aug 10, 2017

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Aug 10, 2017

In #6256, I noticed that we had no tests whatsoever for DataReader.

We should definitely go back and ensure all our classes/modules are tested. Perhaps we can reorganize the test directory too, so the paths/filenames are predictable.

/cc @jekyll/stability

@parkr parkr requested review from pathawks and oe Aug 10, 2017

@pathawks

🤣👍

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 10, 2017

Member

We should add more tests but at least this gets the job started!

@jekyllbot: merge +dev

Member

parkr commented Aug 10, 2017

We should add more tests but at least this gets the job started!

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 3f0c77c into master Aug 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the add-data-reader-test branch Aug 10, 2017

jekyllbot added a commit that referenced this pull request Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment