New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim and relocate plugin info across docs #6311

Merged
merged 1 commit into from Aug 18, 2017

Conversation

Projects
None yet
5 participants
@Strangehill
Contributor

Strangehill commented Aug 14, 2017

fix #6312

@ashmaroli

Changing header ids can break existing urls

Show outdated Hide outdated docs/_docs/templates.md
Show outdated Hide outdated docs/_docs/templates.md
@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli
Member

ashmaroli commented Aug 14, 2017

@DirtyF

I don't really see the value added by this changes, could you share your motivations?

Show outdated Hide outdated docs/_docs/templates.md
Show outdated Hide outdated docs/_docs/plugins.md
Show outdated Hide outdated docs/_docs/plugins.md
Show outdated Hide outdated docs/_docs/plugins.md
Show outdated Hide outdated docs/_docs/plugins.md
@DirtyF

Just update table of contents links and this should be OK. Thanks for helping making docs better. 🎩

Show outdated Hide outdated docs/_docs/plugins.md
Show outdated Hide outdated docs/_docs/templates.md
@DirtyF

DirtyF approved these changes Aug 15, 2017

Thanks a lot @Strangehill

@parkr

This looks pretty good to me! Just a few comments. 💞

Show outdated Hide outdated docs/_docs/plugins.md
Show outdated Hide outdated docs/_docs/plugins.md
Show outdated Hide outdated docs/_docs/plugins.md

@parkr parkr added the documentation label Aug 15, 2017

@Strangehill Strangehill changed the title from move jekyll-gist section, templates to plugins to trim and relocate plugin info across docs Aug 16, 2017

@parkr

parkr approved these changes Aug 18, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 18, 2017

Member

@jekyllbot: merge +docs

Member

parkr commented Aug 18, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 2321370 into jekyll:master Aug 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Aug 18, 2017

@Strangehill Strangehill deleted the Strangehill:patch-3 branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment