New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file to help automate reviews. #6320

Merged
merged 3 commits into from Aug 18, 2017

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Aug 18, 2017

Documentation from GitHub: https://help.github.com/articles/about-codeowners/

I'd like to see GitHub help us keep organized. This new-ish feature will automatically request review from a given team if the files touched match anything declared in the CODEOWNERS file. Instead of a user having to /cc an affinity team, we should declaratively state who owns what and have GitHub require our review.

This is also an exercise in logically splitting up the codebase. The build team is pretty overloaded it looks like -- can we split anything out? 🤷‍♂️

Add CODEOWNERS file to help automate reviews.
Documentation from GitHub: https://help.github.com/articles/about-codeowners/

jekyllbot does too much already -- I'd like to see GitHub help us keep organized.
This is also an exercise in logically splitting up the codebase. The build team
is pretty overloaded it looks like -- can we split anything out?

@parkr parkr requested a review from jekyll/affinity-team-captains Aug 18, 2017

@DirtyF

DirtyF approved these changes Aug 18, 2017 edited

Yeah, no more /cc!

DirtyF added some commits Aug 18, 2017

@pathawks

Brilliant! I hadn't even considered a team owning a file (rather than an individual.

@parkr parkr merged commit b86785d into master Aug 18, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 18, 2017

Member

Thanks, all! I dig your changes, too, @DirtyF.

Member

parkr commented Aug 18, 2017

Thanks, all! I dig your changes, too, @DirtyF.

@parkr parkr deleted the add-CODEOWNERS branch Aug 18, 2017

parkr added a commit that referenced this pull request Aug 18, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Aug 18, 2017

Member

@pathawks same here, discovering we can request review from a team, I'll tend to favor that rather than mentioning people in issues or PRs.

Member

DirtyF commented Aug 18, 2017

@pathawks same here, discovering we can request review from a team, I'll tend to favor that rather than mentioning people in issues or PRs.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Aug 18, 2017

Member

Captains, please do the same to all of our repos

Member

ashmaroli commented Aug 18, 2017

Captains, please do the same to all of our repos

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF
Member

DirtyF commented Aug 18, 2017

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment