GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test files for #2853
add problematic UTF+bom files to fixtures
Let's see if CI fails. It should.
Why? I didn't add a test with this files.
@DirtyF 👍 I'll try to send a PR to your utf8-bom branch which adds failing tests.
Shouldn't this cause the fixture site to fail to build?
add failing test for non-utf8 encoding (#6339)
Merge pull request 6339
@pathawks I just merged @Crunch09 related tests, let's see if CI fails.
I've never been so happy to see CI fail 🤣
Utils.merged_file_read_opts: use a Symbol instead of String for encoding
I have a potential fix in #6433.
Handle both the String and Symbol key cases for prefixing BOM reading…
While you're at it, just set this for site.read_file_opts
Fix some Rubocop errors.
Merge pull request #6433 from jekyll/potential-utf8-bom-fix-parkr
Fix BOM-related read problems
It’s unfortunate that it was basically a typo but hey, it’s fixed!
@jekyllbot: merge +bug
Update history to reflect merge of #6322 [ci skip]
Shoot, I meant to change the title to something that would be more descriptive in the changelog. Oops.
Backport utf8-bom from #6322 to 3.6-stable
Backport utf8-bom from #6322 to 3.6-stable (#6451)