New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic UTF+bom files #6322

Merged
merged 7 commits into from Oct 18, 2017

Conversation

Projects
None yet
5 participants
@DirtyF
Member

DirtyF commented Aug 18, 2017

add test files for #2853

@DirtyF DirtyF requested a review from jekyll/build Aug 18, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 18, 2017

Member

Let's see if CI fails. It should.

Member

parkr commented Aug 18, 2017

Let's see if CI fails. It should.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Aug 18, 2017

Member

Why? I didn't add a test with this files.

Member

DirtyF commented Aug 18, 2017

Why? I didn't add a test with this files.

@Crunch09

This comment has been minimized.

Show comment
Hide comment
@Crunch09

Crunch09 Aug 28, 2017

Member

@DirtyF 👍 I'll try to send a PR to your utf8-bom branch which adds failing tests.

Member

Crunch09 commented Aug 28, 2017

@DirtyF 👍 I'll try to send a PR to your utf8-bom branch which adds failing tests.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 17, 2017

Member

Shouldn't this cause the fixture site to fail to build?

Member

pathawks commented Oct 17, 2017

Shouldn't this cause the fixture site to fail to build?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 17, 2017

Member

@pathawks I just merged @Crunch09 related tests, let's see if CI fails.

Member

DirtyF commented Oct 17, 2017

@pathawks I just merged @Crunch09 related tests, let's see if CI fails.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 17, 2017

Member

I've never been so happy to see CI fail 🤣

Member

pathawks commented Oct 17, 2017

I've never been so happy to see CI fail 🤣

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 17, 2017

Member

I have a potential fix in #6433.

Member

parkr commented Oct 17, 2017

I have a potential fix in #6433.

@parkr

parkr approved these changes Oct 18, 2017

It’s unfortunate that it was basically a typo but hey, it’s fixed!

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 18, 2017

Member

@jekyllbot: merge +bug

Member

pathawks commented Oct 18, 2017

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 363bd6c into master Oct 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Oct 18, 2017

@jekyllbot jekyllbot deleted the utf8-bom branch Oct 18, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 18, 2017

Member

Shoot, I meant to change the title to something that would be more descriptive in the changelog. Oops.

Member

pathawks commented Oct 18, 2017

Shoot, I meant to change the title to something that would be more descriptive in the changelog. Oops.

pathawks added a commit that referenced this pull request Oct 20, 2017

pathawks added a commit that referenced this pull request Oct 20, 2017

@pathawks pathawks referenced this pull request Oct 20, 2017

Closed

Release 3.6.2 #6454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment