New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds on codeclimate #6333

Merged
merged 1 commit into from Aug 30, 2017

Conversation

Projects
None yet
3 participants
@DirtyF
Member

DirtyF commented Aug 26, 2017

Builds currently fail on codeclmate: https://codeclimate.com/github/jekyll/jekyll/builds

It's because default rubocop engine is 0.46 and we use 0.49 with new cops.

Local tests

With default channel:

~/code/jekyll/jekyll
$ codeclimate analyze -e rubocop:rubocop-0-46
Starting analysis
Running rubocop: Done!
error: (CC::Analyzer::Engine::EngineFailure) engine rubocop:rubocop-0-46 failed with status 1 and stderr
...

When using corresponding channel:

~/code/jekyll/jekyll
$ codeclimate analyze -e rubocop:rubocop-0-49
Starting analysis
Running rubocop: Done!

Analysis complete! Found 0 issues.

@DirtyF DirtyF added the tests label Aug 26, 2017

@DirtyF DirtyF requested a review from jekyll/build Aug 26, 2017

@parkr

parkr approved these changes Aug 30, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 30, 2017

Member

@jekyllbot: merge +dev

Member

parkr commented Aug 30, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 94f377e into jekyll:master Aug 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Aug 30, 2017

@DirtyF DirtyF deleted the DirtyF:codeclimate-rubocop branch Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment