Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mime-types. #6336

Merged
merged 1 commit into from Aug 30, 2017
Merged

Update mime-types. #6336

merged 1 commit into from Aug 30, 2017

Conversation

@bmeck
Copy link
Contributor

bmeck commented Aug 29, 2017

ran script/vendor-mimes

@bmeck

This comment has been minimized.

Copy link
Contributor Author

bmeck commented Aug 29, 2017

I'm not 100% sure how versioning works here, but want to make a follow up PR to https://github.com/github/pages-gem whenever this gets merged. It looks like the versions currently used are at https://pages.github.com/versions/ , and just want to be sure I make the PR to the right version if/when this gets lands in a version.

@ashmaroli

This comment has been minimized.

Copy link
Member

ashmaroli commented Aug 29, 2017

jekyll/jekyll follows Semantic Versioning

@bmeck

This comment has been minimized.

Copy link
Contributor Author

bmeck commented Aug 29, 2017

@ashmaroli understood, but those rules of what a breaking change are vague. I know in nodejs/node almost any changes to existing behavior are breaking, so this would be considered breaking/major?

@ashmaroli

This comment has been minimized.

Copy link
Member

ashmaroli commented Aug 29, 2017

mime-types is not part of the the Public API per se.. it seems to come into play only while running the default WEBrick server ($ jekyll serve)

But I'll defer to the word from the maintainers on this one..

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Aug 29, 2017

@bmeck The GitHub team updates these mime types independently - they're not pulled in from the Jekyll gem. Which mime type are you looking to update?

@parkr
parkr approved these changes Aug 30, 2017
@bmeck

This comment has been minimized.

Copy link
Contributor Author

bmeck commented Aug 30, 2017

@parkr .mjs files to be application/javascript. Matches github/linguist#3783

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Aug 30, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 53500a2 into jekyll:master Aug 30, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jekyllbot added a commit that referenced this pull request Aug 30, 2017
@parkr

This comment has been minimized.

Copy link
Member

parkr commented Aug 30, 2017

@bmeck Ok, I'll see if we can get an update going on Pages. No promises. The best thing to do in the future is to email GitHub Support asking us to update our MIME types for GitHub Pages. They pass it along to the appropriate team.

@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.