New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failing test for non-utf8 encoding #6339

Merged
merged 2 commits into from Oct 17, 2017

Conversation

Projects
None yet
5 participants
@Crunch09
Member

Crunch09 commented Aug 30, 2017

Based on the files provided by @DirtyF . At least the UTF-16 one did fail for me locally so hopefully it will also fail on CI. Happy to try to fix the issue but won't have time before the weekend.

cc: @jekyll/build

@parkr

Thank you so much! Just one update requested then we should be good.

Show outdated Hide outdated test/test_document.rb Outdated
@Crunch09

This comment has been minimized.

Show comment
Hide comment
@Crunch09

Crunch09 Aug 31, 2017

Member

Thanks, good point 👍 Fixed that

Member

Crunch09 commented Aug 31, 2017

Thanks, good point 👍 Fixed that

@DirtyF DirtyF added this to the v3.7.0 milestone Sep 24, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 17, 2017

Member

@jekyllbot: merge +dev

Member

DirtyF commented Oct 17, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit c5c4201 into jekyll:utf8-bom Oct 17, 2017

@Crunch09 Crunch09 deleted the Crunch09:failing_test_for_utf8_bom branch Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment