New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutable drops should fallback to their own methods when a mutation isn't present #6350

Merged
merged 3 commits into from Sep 21, 2017

Conversation

Projects
None yet
3 participants
@benbalter
Contributor

benbalter commented Sep 7, 2017

A follow up to #6338 and discovered via jekyll/github-metadata#112, the current logic for Jekyll::Drops::Drop#key? for mutable drops is to look for a mutated key, but then not to look for a native method or fallback data. Instead, Drops should look for a key in the mutated data, in native methods, AND in fallback data.

This PR updates the logic of Drop#key? and includes tests to ensure the method does what we expect it to going forward.

benbalter added some commits Sep 7, 2017

@parkr

parkr approved these changes Sep 21, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 21, 2017

Member

@benbalter Should this be backported and released as v3.5.3?

Member

parkr commented Sep 21, 2017

@benbalter Should this be backported and released as v3.5.3?

@parkr parkr added bug fix labels Sep 21, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 21, 2017

Member

@jekyllbot: merge +bug

Member

parkr commented Sep 21, 2017

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit a5fd0c0 into master Sep 21, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Sep 21, 2017

@jekyllbot jekyllbot deleted the mutable-drop-methods branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment