Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upBump rubocop to use `v0.50.x` #6368
Conversation
ashmaroli
added some commits
Sep 15, 2017
| @@ -86,7 +86,7 @@ def fsnotify_buggy?(_site) | ||
| def urls_only_differ_by_case(site) | ||
| urls_only_differ_by_case = false | ||
| urls = case_insensitive_urls(site.pages + site.docs_to_write, site.dest) | ||
| urls.each do |_case_insensitive_url, real_urls| | ||
| urls.each_value do |real_urls| |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
parkr
reviewed
Sep 15, 2017
Nice! One code update suggestion and some thoughts on the configuration changes. Instead of turning them off, it might be better to exclude certain files if we decide that the rule is helpful (most are).
| @@ -42,12 +42,14 @@ def convert(content) | ||
| end | ||
| private | ||
| # rubocop:disable Performance/HashEachMethods | ||
| def make_accessible(hash = @config) | ||
| hash.keys.each do |key| |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
| @@ -82,6 +86,12 @@ Metrics/ParameterLists: | ||
| Max: 4 | ||
| Metrics/PerceivedComplexity: | ||
| Max: 8 | ||
| Naming/FileName: | ||
| Enabled: false |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ashmaroli
Sep 15, 2017
Member
From their docs,
This cop makes sure that Ruby source files have snake_case names. Ruby scripts (i.e. source files with a shebang in the first line) are ignored.
and flags us for the following:
- 'Gemfile'
- 'Rakefile'
- 'lib/theme_template/Gemfile'
- 'test/fixtures/test-dependency-theme/test-dependency-theme.gemspec'
- 'test/fixtures/test-theme/test-theme.gemspec'
which IMO is a bug because this cop existed as an enabled-by-default-cop earlier known as Style/FileName
ashmaroli
Sep 15, 2017
Member
From their docs,
This cop makes sure that Ruby source files have snake_case names. Ruby scripts (i.e. source files with a shebang in the first line) are ignored.
and flags us for the following:
- 'Gemfile'
- 'Rakefile'
- 'lib/theme_template/Gemfile'
- 'test/fixtures/test-dependency-theme/test-dependency-theme.gemspec'
- 'test/fixtures/test-theme/test-theme.gemspec'
which IMO is a bug because this cop existed as an enabled-by-default-cop earlier known as Style/FileName
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
.rubocop.yml Outdated
.rubocop.yml Outdated
.rubocop.yml Outdated
| Lint/UnreachableCode: | ||
| Severity: error | ||
| Lint/UselessAccessModifier: | ||
| Enabled: false | ||
| Lint/Void: | ||
| Enabled: false |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ashmaroli
Sep 15, 2017
Member
This cop checks for the use of a return with a value in a context where it will be ignored.
In our case specifically, this cop (incorrectly ?) flags Site#config= similar to the documented example
ashmaroli
Sep 15, 2017
Member
This cop checks for the use of a return with a value in a context where it will be ignored.
In our case specifically, this cop (incorrectly ?) flags Site#config= similar to the documented example
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
parkr
Sep 21, 2017
Member
Oh we must return some value and it doesn't like that! We can enable it in a subsequent pass.
parkr
Sep 21, 2017
Member
Oh we must return some value and it doesn't like that! We can enable it in a subsequent pass.
| @@ -44,10 +44,14 @@ Layout/SpaceInsideBrackets: | ||
| Enabled: false | ||
| Lint/EndAlignment: | ||
| Severity: error | ||
| Lint/RescueWithoutErrorClass: | ||
| Enabled: false |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ashmaroli
Sep 15, 2017
Member
I wasn't sure about it though, since unnamed rescue means rescuing StandardError by default.
ashmaroli
Sep 15, 2017
Member
I wasn't sure about it though, since unnamed rescue means rescuing StandardError by default.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
parkr
Sep 21, 2017
Member
Yeah, but it's always better to rescue explicitly what you want to rescue instead of everything. We can do this in a subsequent pass.
parkr
Sep 21, 2017
Member
Yeah, but it's always better to rescue explicitly what you want to rescue instead of everything. We can do this in a subsequent pass.
| @@ -21,7 +21,7 @@ Layout/EmptyLinesAroundAccessModifier: | ||
| Layout/EmptyLinesAroundModuleBody: | ||
| Enabled: false | ||
| Layout/EndOfLine: | ||
| EnforcedStyle: lf | ||
| EnforcedStyle: native |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ashmaroli
Sep 15, 2017
Member
Technically, we do.. but if a developer on Windows were to run script/fmt they'd unnecessarily get taxed by Rubocop. In my own experience, it has been irritating..
A properly configured Git on Windows automatically indexes files compatible for cross-platform use.
ashmaroli
Sep 15, 2017
Member
Technically, we do.. but if a developer on Windows were to run script/fmt they'd unnecessarily get taxed by Rubocop. In my own experience, it has been irritating..
A properly configured Git on Windows automatically indexes files compatible for cross-platform use.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ashmaroli
added some commits
Sep 15, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@jekyllbot: merge +dev |
ashmaroli commentedSep 15, 2017
Fixes #6367