New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rouge 3 #6381

Merged
merged 1 commit into from Sep 23, 2017

Conversation

Projects
None yet
5 participants
@DirtyF
Member

DirtyF commented Sep 23, 2017

Rouge got recently updated to v3.0.

The major version bump is due to jneen/rouge#763 but doesn't impact our test suite.

@DirtyF DirtyF added the dependency label Sep 23, 2017

@DirtyF DirtyF requested review from Crunch09 and pathawks Sep 23, 2017

@DirtyF DirtyF added this to the v3.7.0 milestone Sep 23, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 23, 2017

Member

It might be nice to release this fairly soon, but the v3.7.0 milestone looks a bit heavy. I wonder if we could just pick some low hanging fruit?

Member

pathawks commented Sep 23, 2017

It might be nice to release this fairly soon, but the v3.7.0 milestone looks a bit heavy. I wonder if we could just pick some low hanging fruit?

@Crunch09

👍

@oe

oe approved these changes Sep 23, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 23, 2017

Member

@jekyllbot: merge +minor

Member

pathawks commented Sep 23, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 5f8ba18 into master Sep 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the rouge-3 branch Sep 23, 2017

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Sep 23, 2017

Member

@pathawks is this important enough to bump up the priority of releasing a new jekyll version? it just seems to change some internal things and remove support for ruby 1.9 (unless i'm missing something)

Member

oe commented Sep 23, 2017

@pathawks is this important enough to bump up the priority of releasing a new jekyll version? it just seems to change some internal things and remove support for ruby 1.9 (unless i'm missing something)

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 23, 2017

Member

If there is some bugfix or something in Rouge 3.0.1 or Rouge 3.1.0, I wouldn't want Jekyll users to be unable to update.

Member

pathawks commented Sep 23, 2017

If there is some bugfix or something in Rouge 3.0.1 or Rouge 3.1.0, I wouldn't want Jekyll users to be unable to update.

@DirtyF DirtyF referenced this pull request Sep 28, 2017

Closed

Upgrade to Rouge 2.0 #5556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment