New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for theme-gem installation #6387

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Sep 27, 2017

Ref: Question at Jekyll Talk and another at StackOverflow

/cc @jekyll/documentation

@jekyllbot jekyllbot requested review from DirtyF and parkr Sep 27, 2017

@DirtyF

Not related to your change, but we better fix the current diff ugly highlight style.

diff-style-jekyll

Maybe we could avoir using diff for now?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 27, 2017

Member

I've already prepared that locally.. will start another PR once this is merged..
started #6388 for discussions before this gets merged..

Member

ashmaroli commented Sep 27, 2017

I've already prepared that locally.. will start another PR once this is merged..
started #6388 for discussions before this gets merged..

@DirtyF

DirtyF approved these changes Sep 27, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Sep 27, 2017

Member

@jekyllbot: merge +docs

Thanks @ashmaroli

Member

DirtyF commented Sep 27, 2017

@jekyllbot: merge +docs

Thanks @ashmaroli

@jekyllbot jekyllbot merged commit eadad9e into jekyll:master Sep 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:theme-docs branch Sep 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment