New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special styling for code-blocks run in shell #6389

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
5 participants
@ashmaroli
Member

ashmaroli commented Sep 27, 2017

Proposing to add additional styling to indicate code-blocks with sh syntax-highlighting for added discernibility..

Sample preview:

shell-syntax

Additional benefits:

  • This will allow us to easily detect which of the blocks have incorrectly highlighted as shell-syntax
  • consistently use sh for shell-highlighting..

/cc @jekyll/documentation

@jekyllbot jekyllbot requested review from DirtyF and parkr Sep 27, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Sep 27, 2017

Member

I like this, as it resolves the problem of having to prefix with a $ sign for shell commands and thus allows easier copy-pasting for users.

ProTip™: Remark presets are our friend to ensure consistency:

Member

DirtyF commented Sep 27, 2017

I like this, as it resolves the problem of having to prefix with a $ sign for shell commands and thus allows easier copy-pasting for users.

ProTip™: Remark presets are our friend to ensure consistency:

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 27, 2017

Member

Nice.. are there any related Linters in Ruby world..? If yes, we could add that to our Travis matrix as well..

Member

ashmaroli commented Sep 27, 2017

Nice.. are there any related Linters in Ruby world..? If yes, we could add that to our Travis matrix as well..

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF
Member

DirtyF commented Sep 27, 2017

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Sep 29, 2017

Member

Is there a way to make the color of the TERMINAL bit the yellow color we use throughout the rest of the site? If so, I'd like to see a screenshot of what that looks like for comparision purposes. It feels like the black text on the gray background washes out the border a bit. Just my 2¢. 😃

Member

mattr- commented Sep 29, 2017

Is there a way to make the color of the TERMINAL bit the yellow color we use throughout the rest of the site? If so, I'd like to see a screenshot of what that looks like for comparision purposes. It feels like the black text on the gray background washes out the border a bit. Just my 2¢. 😃

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Sep 29, 2017

Member

It feels like the black text on the gray background washes out the border a bit

I was shooting for a subtle-indication actually.. IMO, the yellow would only be visual noise..

Black Terminal

terminal

Yellow Terminal

yellow-terminal

Member

ashmaroli commented Sep 29, 2017

It feels like the black text on the gray background washes out the border a bit

I was shooting for a subtle-indication actually.. IMO, the yellow would only be visual noise..

Black Terminal

terminal

Yellow Terminal

yellow-terminal

@mattr-

mattr- approved these changes Sep 29, 2017

After seeing both, I'm a fan of the black text. :shipit:

@DirtyF

DirtyF approved these changes Sep 29, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Sep 29, 2017

Member

@jekyllbot: merge +site

Member

DirtyF commented Sep 29, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 76c52f4 into jekyll:master Sep 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:bash-code-block branch Oct 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment