New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a better default hash for tracking liquid stats #6417

Merged
merged 1 commit into from Oct 7, 2017

Conversation

Projects
None yet
3 participants
@mattr-
Member

mattr- commented Oct 7, 2017

This avoids doing the ||= check for an existing value when setting values for the per-file stats hash in the liquid renderer. It also gives us the flexibility to add new numerical values to this hash later without having to do the same ||= check as we can just know that the starting value will be zero.

Discovered while I was investigating #6241

Provide a better default hash for tracking liquid stats
This avoids doing the `||=` check for an existing value when setting
values for the per-file stats hash in the liquid renderer. It also gives
us the flexibility to add new numerical values to this hash later
without having to do the same `||=` check as we can just know that the
starting value will be zero.

@DirtyF DirtyF requested a review from jekyll/build Oct 7, 2017

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Oct 7, 2017

Member

@jekyllbot: merge +dev

Member

mattr- commented Oct 7, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit d484124 into master Oct 7, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the improve-hash-handling-for-liquid-renderer branch Oct 7, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 8, 2017

Member

Thanks @mattr- 🍻🎊

Member

pathawks commented Oct 8, 2017

Thanks @mattr- 🍻🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment