New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for first-timers bot #6431

Merged
merged 3 commits into from Oct 18, 2017

Conversation

Projects
None yet
6 participants
@pathawks
Member

pathawks commented Oct 17, 2017

From the discussion at https://github.com/jekyll/community/issues/6, we have decided to add First Timers bot to this repository. The reason we are doing this is to help on-board new contributors to the project.

The way this works is that maintainers create special branches prefixed with first-timers- and commit needed changes to that branch. When the branch is pushed to jekyll/jekyll, the bot will create an issue template with step-by-step instructions to walk a first-timer through committing those changes to their own branch and then creating a PR.

This is a very hand-holding process, and will certainly slow things down a bit: rather than a maintainer merging their own changes, they will go through all the steps of committing the changes and then wait for a first-timer to follow the issue template to make the changes a second time.

BUT the benefits have the potential to out weigh those costs. Our community could use some fresh talent, and if we can get some new contributors over the hump of committing a first PR, we will grow our community.

The tag good first issue will be added to issues created by the bot, because GitHub says it will help get these issues in front of the right people:

Add labels for new contributors

Now, GitHub will help potential first-time contributors discover issues labeled with help wanted or good first issue

Issue template was adapted from https://github.com/hoodiehq/first-timers-bot/blob/bacbc8e80da97cb9d5ca254587c55cf7f48c0f99/instructions.md

Configuration was adapted from https://github.com/hoodiehq/first-timers-bot/blob/bacbc8e80da97cb9d5ca254587c55cf7f48c0f99/.github/first-timers.yml

I have not yet added the bot to this repo. I will do so after this is merged.

@pathawks pathawks self-assigned this Oct 17, 2017

@pathawks pathawks requested review from DirtyF and oe Oct 17, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF
Member

DirtyF commented Oct 17, 2017

@pathawks you didn't use https://probot.github.io/ 😢

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Oct 17, 2017

Member

@DirtyF i believe the github app is the same anyways, probot is just the framework it uses?

Member

oe commented Oct 17, 2017

@DirtyF i believe the github app is the same anyways, probot is just the framework it uses?

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 17, 2017

Member

@DirtyF This is the Fist Timers Bot from that page 👍

Member

pathawks commented Oct 17, 2017

@DirtyF This is the Fist Timers Bot from that page 👍

@DirtyF

I'd rather go with probot as setting Probot up on this repo will allow us to automate other community related tasks.

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Oct 17, 2017

Member

@DirtyF i think all of the probot functionalities are just separate apps (e.g. the stale app) that you'd need to install independently anyways

Member

oe commented Oct 17, 2017

@DirtyF i think all of the probot functionalities are just separate apps (e.g. the stale app) that you'd need to install independently anyways

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 17, 2017

Member

@pup I'd rather go with the same bot on the repo for all the behavior tasks, it might even replace our dear @jekyllbot one day 😭

Member

DirtyF commented Oct 17, 2017

@pup I'd rather go with the same bot on the repo for all the behavior tasks, it might even replace our dear @jekyllbot one day 😭

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Oct 17, 2017

Member

@DirtyF is that a possibility? can probot combine all of that into one github app?

Member

oe commented Oct 17, 2017

@DirtyF is that a possibility? can probot combine all of that into one github app?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 17, 2017

Member

@pup No, you're right it adds an app for each plugin.

Member

DirtyF commented Oct 17, 2017

@pup No, you're right it adds an app for each plugin.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 17, 2017

Member

@DirtyF So... is this the bot we are all talking about, or did you have something else in mind?

Member

pathawks commented Oct 17, 2017

@DirtyF So... is this the bot we are all talking about, or did you have something else in mind?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 17, 2017

Member

@pathawks yes it is.

Member

DirtyF commented Oct 17, 2017

@pathawks yes it is.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 17, 2017

Member

Just waiting for a review then 👍

Member

pathawks commented Oct 17, 2017

Just waiting for a review then 👍

@oe

oe approved these changes Oct 17, 2017

Team members cannot assign themselves to issues
They can be _assigned_ to issues, however.
@DirtyF

DirtyF approved these changes Oct 17, 2017 edited

what about first-time-only label?

Add `first-time-only` label
If we go to all the trouble to create these PR walkthroughs, we want to
emphasize that they are intended for first-timers.
@Crunch09

This comment has been minimized.

Show comment
Hide comment
@Crunch09

Crunch09 Oct 17, 2017

Member

👍 Great idea!

From the discussion at jekyll/community#6 [...]

How can we follow this discussion? Or is this repo for maintainers only? (which would totally be fine!)

Member

Crunch09 commented Oct 17, 2017

👍 Great idea!

From the discussion at jekyll/community#6 [...]

How can we follow this discussion? Or is this repo for maintainers only? (which would totally be fine!)

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 17, 2017

Member

How can we follow this discussion? Or is this repo for maintainers only?

Apparently it's private. Sorry.

FWIW, the discussion was moved here very quickly. You're not really missing anything.

Member

pathawks commented Oct 17, 2017

How can we follow this discussion? Or is this repo for maintainers only?

Apparently it's private. Sorry.

FWIW, the discussion was moved here very quickly. You're not really missing anything.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 17, 2017

Member

@Crunch09 How come you're not part of the maintainers?

Member

DirtyF commented Oct 17, 2017

@Crunch09 How come you're not part of the maintainers?

@Crunch09

This comment has been minimized.

Show comment
Hide comment
@Crunch09

Crunch09 Oct 17, 2017

Member

@pathawks Thank you, all good 👍
@DirtyF Why would i? 🙂 Not sure what the path to becoming a maintainer is, i am part of some affinity teams, though!

Member

Crunch09 commented Oct 17, 2017

@pathawks Thank you, all good 👍
@DirtyF Why would i? 🙂 Not sure what the path to becoming a maintainer is, i am part of some affinity teams, though!

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 17, 2017

Member

I'm not even sure which team grants access to that repo, to be honest.

Member

pathawks commented Oct 17, 2017

I'm not even sure which team grants access to that repo, to be honest.

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Oct 17, 2017

Member

it's a mostly obsolete repo anyways, it can basically be deleted right now

Member

oe commented Oct 17, 2017

it's a mostly obsolete repo anyways, it can basically be deleted right now

@pathawks pathawks added the internal label Oct 17, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 17, 2017

Member

Whoops! It looks like I am not authorized to add bots to @jekyll after all.

@parkr: Would you mind installing first-timers-bot and merging this PR?

Member

pathawks commented Oct 17, 2017

Whoops! It looks like I am not authorized to add bots to @jekyll after all.

@parkr: Would you mind installing first-timers-bot and merging this PR?

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 17, 2017

Member

I apologize. I didn't realize that only organization owners can install apps on repos owned by that organization. I should have checked with @parkr at the beginning instead of the end of this process. Sorry about that. It was not my intent to step on any toes.

Member

pathawks commented Oct 17, 2017

I apologize. I didn't realize that only organization owners can install apps on repos owned by that organization. I should have checked with @parkr at the beginning instead of the end of this process. Sorry about that. It was not my intent to step on any toes.

@pathawks pathawks removed their assignment Oct 17, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 18, 2017

Member

Installed! Not sure why you weren't able to install it...

@jekyllbot: merge +dev

Member

parkr commented Oct 18, 2017

Installed! Not sure why you weren't able to install it...

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit c6b8906 into master Oct 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pr/first-timers-config branch Oct 18, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 18, 2017

Member

And here it is in action: #6436 🎉

Member

pathawks commented Oct 18, 2017

And here it is in action: #6436 🎉

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Oct 18, 2017

Member

@parkr i think only org owners can? core team membership !== org ownership

Member

oe commented Oct 18, 2017

@parkr i think only org owners can? core team membership !== org ownership

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 18, 2017

Member

I wonder if this is worth a blog post?

Member

pathawks commented Oct 18, 2017

I wonder if this is worth a blog post?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 18, 2017

Member

@pathawks at least it deserves a tweet. Maybe we wait a bit, create more first-timer-only issues, see how it goes before publishing a blog post? I'm pretty confident @pup will be more than happy to write about this.

Member

DirtyF commented Oct 18, 2017

@pathawks at least it deserves a tweet. Maybe we wait a bit, create more first-timer-only issues, see how it goes before publishing a blog post? I'm pretty confident @pup will be more than happy to write about this.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 18, 2017

Member

Huge 👍 to a blog post. Don't wait too long, lest we forget about it! You could do an announcement post, then, in a month or two, a retrospective post about how it's working. 💭

Member

parkr commented Oct 18, 2017

Huge 👍 to a blog post. Don't wait too long, lest we forget about it! You could do an announcement post, then, in a month or two, a retrospective post about how it's working. 💭

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Oct 18, 2017

Member

@parkr alright! i'll work on that tomorrow then

Member

oe commented Oct 18, 2017

@parkr alright! i'll work on that tomorrow then

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 18, 2017

Member

@pup If you feel comfortable! I think writing one soon is a great idea (could be the next week or two) but totally up to you. Just meant to put my support behind a blog post if one is desired 😸

Member

parkr commented Oct 18, 2017

@pup If you feel comfortable! I think writing one soon is a great idea (could be the next week or two) but totally up to you. Just meant to put my support behind a blog post if one is desired 😸

@oe oe referenced this pull request Oct 19, 2017

Merged

add post about diversity #6447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment