Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always treat `data.layout` as a string #6442

Merged
merged 1 commit into from Oct 19, 2017

Conversation

@bellvat
Copy link
Contributor

bellvat commented Oct 19, 2017

Added 'to_s' method to line 146.
Can you review my code change?

Add 'to_s' method to line 146.
@pathawks

This comment has been minimized.

Copy link
Member

pathawks commented Oct 19, 2017

Fixes #6436
Fixes #6190

Copy link
Member

pathawks left a comment

Excellent work! We just need to wait for our Continuous Integration test suite to give us a green checkmark and this can be merged 👍🏼

@pathawks pathawks changed the title Updated 'data.layout' to a string. Always treat `data.layout` as a string Oct 19, 2017
@pathawks

This comment has been minimized.

Copy link
Member

pathawks commented Oct 19, 2017

AppVeyor failure is due to SSL error; unrelated to PR.

@pathawks

This comment has been minimized.

Copy link
Member

pathawks commented Oct 19, 2017

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 84c2503 into jekyll:master Oct 19, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jekyllbot jekyllbot added bug fix labels Oct 19, 2017
jekyllbot added a commit that referenced this pull request Oct 19, 2017
@pathawks

This comment has been minimized.

Copy link
Member

pathawks commented Oct 19, 2017

Thanks again, @bellvat! 🎊🌮

pathawks added a commit that referenced this pull request Oct 20, 2017
pathawks added a commit that referenced this pull request Oct 20, 2017
@pathawks pathawks mentioned this pull request Oct 20, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.