New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not linkify escaped characters as PRs in History #6468

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
5 participants
@jekyllbot
Contributor

jekyllbot commented Oct 23, 2017

PR automatically created for @pathawks.

Do not linkify escaped characters as PRs in History

Fixes #6461

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 23, 2017

Member

The regular expression that we were using to match PRs in the format #123 was also matching escaped characters in the format { which was causing weird things to happen in the generated history on the website.

Thanks to @ashmaroli for pointing out this problem.

Member

pathawks commented Oct 23, 2017

The regular expression that we were using to match PRs in the format #123 was also matching escaped characters in the format { which was causing weird things to happen in the generated history on the website.

Thanks to @ashmaroli for pointing out this problem.

@pathawks pathawks added the site label Oct 23, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks
Member

pathawks commented Oct 23, 2017

Show outdated Hide outdated Rakefile Outdated
@DirtyF

DirtyF approved these changes Oct 23, 2017

@parkr

parkr approved these changes Oct 23, 2017

oh lord! this code is not tested... 😆

@mattr-

mattr- approved these changes Oct 23, 2017

:shipit:

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Oct 23, 2017

Member

oh lord! this code is not tested... 😆

😂😂😂😂

@jekyllbot: merge +dev

Member

mattr- commented Oct 23, 2017

oh lord! this code is not tested... 😆

😂😂😂😂

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 3bd808c into master Oct 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/linkify_pr branch Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment