New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on jekyll-mentions for linking usernames #6469

Merged
merged 2 commits into from Oct 26, 2017

Conversation

Projects
None yet
4 participants
@jekyllbot
Contributor

jekyllbot commented Oct 23, 2017

PR automatically created for @pathawks.

Rely on jekyll-mentions for linking usernames

This is more robust than our regex as it will not link anything that is
inside of backticks, like `@config` or `@options`

@pathawks pathawks changed the title from Rely on jekyll-mentions for linking usernames This is more robust than our regex as it will not link anything that is inside of backticks, like `@config` or `@options` to Rely on jekyll-mentions for linking usernames Oct 23, 2017

@pathawks pathawks added the site label Oct 23, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks
Member

pathawks commented Oct 23, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 23, 2017

Member

And jekyll-mentions is included in our site config already. 👍

jekyll/docs/_config.yml

Lines 48 to 55 in c0e4ce1

plugins:
- jekyll-avatar
- jekyll-feed
- jekyll-mentions
- jekyll-redirect-from
- jekyll-seo-tag
- jekyll-sitemap
- jemoji

Member

pathawks commented Oct 23, 2017

And jekyll-mentions is included in our site config already. 👍

jekyll/docs/_config.yml

Lines 48 to 55 in c0e4ce1

plugins:
- jekyll-avatar
- jekyll-feed
- jekyll-mentions
- jekyll-redirect-from
- jekyll-seo-tag
- jekyll-sitemap
- jemoji

Rely on jekyll-mentions for linking usernames
This is more robust than our regex as it will not link anything that is
inside of backticks, like `@config` or `@options`
Show outdated Hide outdated docs/_docs/history.md Outdated
def linkify(markdown)
linkify_users(linkify_prs(markdown))
linkify_prs(markdown)
end

This comment has been minimized.

@DirtyF

DirtyF Oct 23, 2017

Member

So this function is useless (for) now, we can directly call linkify_prs in converted_history

@DirtyF

DirtyF Oct 23, 2017

Member

So this function is useless (for) now, we can directly call linkify_prs in converted_history

@DirtyF

DirtyF approved these changes Oct 26, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 26, 2017

Member

@jekyllbot: merge +dev

Member

DirtyF commented Oct 26, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit e0eff96 into master Oct 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/mentions branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment