New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site: Add default twitter card image #6476

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
5 participants
@jekyllbot
Contributor

jekyllbot commented Oct 23, 2017

Given I share a post from jekyllrb.com
Then Twitter Card displays the Jekyll logo by default

Current status:
capture d ecran 2017-10-23 a 21 07 05

Hopefully we use jekyll-seo-tag who can take care of that 馃槃

PR automatically created for @DirtyF.

Site: Add default twitter card image

@DirtyF DirtyF added the site label Oct 23, 2017

@DirtyF DirtyF requested a review from jekyll/administrators Oct 23, 2017

@oe

oe approved these changes Oct 23, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 23, 2017

Member

Does it expand out to use site.url?

Member

parkr commented Oct 23, 2017

Does it expand out to use site.url?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 23, 2017

Member

@parker it does according to my tests, I basically followed the plugin documentation. I trust @benbalter on this 馃槃

Member

DirtyF commented Oct 23, 2017

@parker it does according to my tests, I basically followed the plugin documentation. I trust @benbalter on this 馃槃

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 23, 2017

Member

@jekyllbot: merge +site

Member

DirtyF commented Oct 23, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 8d88ee9 into master Oct 23, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/site-twitter-card branch Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment