New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URL filters to work directly with documents #6478

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
7 participants
@pathawks
Member

pathawks commented Oct 24, 2017

I may have proposed this before, but I'm curious if anybody else would be interested in URL filters that work directly with documents.

Instead of {{ page.url | absolute_url }} this would allow {{ page | absolute_url }} which feels just a little nicer to me. Curious to hear other's thoughts.

/cc: @jekyll/build @jekyll/ecosystem

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 24, 2017

Member

What's the use-case for it? It seems fine, but it might confuse folks as being a bit magical. The primary requirement for the url filters is that they're chainable: input must allow URL, output must be URL. If this is just allowing an extra possible input, then I'm open to it.

Member

parkr commented Oct 24, 2017

What's the use-case for it? It seems fine, but it might confuse folks as being a bit magical. The primary requirement for the url filters is that they're chainable: input must allow URL, output must be URL. If this is just allowing an extra possible input, then I'm open to it.

@parkr

parkr approved these changes Oct 24, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 24, 2017

Member

You’re right, this probably isn’t worth the added complexity.

Member

pathawks commented Oct 24, 2017

You’re right, this probably isn’t worth the added complexity.

@pathawks pathawks closed this Oct 24, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 24, 2017

Member

New users would find this useful (those who don't know you need to call page.url), so that's why I approved it.

Member

parkr commented Oct 24, 2017

New users would find this useful (those who don't know you need to call page.url), so that's why I approved it.

@pathawks pathawks reopened this Oct 24, 2017

@Crunch09

👍

@ashmaroli ashmaroli added accepted and removed discussion labels Nov 10, 2017

@ashmaroli ashmaroli changed the title from Proposal: Allow URL filters to work directly with documents to Allow URL filters to work directly with documents Nov 10, 2017

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 10, 2017

Member

@pathawks Please appease RuboCop here 😃

Member

ashmaroli commented Nov 10, 2017

@pathawks Please appease RuboCop here 😃

@oe

oe approved these changes Nov 10, 2017

LGTM after rubocop fixes!

@DirtyF DirtyF added this to the v3.7.0 milestone Nov 10, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks
Member

pathawks commented Nov 10, 2017

@ashmaroli

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 10, 2017

Member

@jekyllbot: merge +minor

Member

DirtyF commented Nov 10, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 5821658 into master Nov 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the url-filters branch Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment