Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable `Lint/RescueWithoutErrorClass` Cop #6482

Merged
merged 1 commit into from Oct 28, 2017

Conversation

Projects
None yet
5 participants
@ashmaroli
Copy link
Member

ashmaroli commented Oct 26, 2017

RuboCop sez it's not a good practice to rescue an Exception without specifying an ::Exception subclass.
So lets specify the classes, then.

In many of the offenses encountered, the rescue covers a broad range and a particular class is not readily discernible. Hence, correct such offenses by rescue-ing the default class for rescueStandardError
The remaining offenses have been corrected by assuming the most likely by manually interpreting the code context.

/cc @pathawks

@DirtyF DirtyF added the internal label Oct 26, 2017

@DirtyF DirtyF requested a review from pathawks Oct 26, 2017

@pathawks

This comment has been minimized.

Copy link
Member

pathawks commented Oct 26, 2017

@ashmaroli ashmaroli force-pushed the ashmaroli:lint-rescue-no-classes branch from 6f53c5f to 994eaea Oct 27, 2017

@ashmaroli

This comment has been minimized.

Copy link
Member Author

ashmaroli commented Oct 27, 2017

I can't figure out what AppVeyor is upset about.

It's just a momentary glitch.. I pushed a rehashed version of the commit to "trigger a new build"

@pathawks
Copy link
Member

pathawks left a comment

Thanks for the comments.
This is better 👍

@DirtyF

DirtyF approved these changes Oct 27, 2017

@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented Oct 28, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 9632733 into jekyll:master Oct 28, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Oct 28, 2017

@ashmaroli ashmaroli deleted the ashmaroli:lint-rescue-no-classes branch Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.