New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `sudo` from macOS troubleshooting instructions #6486

Merged
merged 1 commit into from Oct 28, 2017

Conversation

Projects
None yet
7 participants
@andrewda
Member

andrewda commented Oct 27, 2017

It should be made very clear that sudo is not recommended on macOS, so the examples should show the commands without sudo. If the user knows what they're doing, they can prepend sudo themselves as the note suggests.

/cc @jekyll/documentation

@jekyllbot jekyllbot requested review from DirtyF, mattr- and parkr Oct 27, 2017

@DirtyF

DirtyF approved these changes Oct 27, 2017

Thank you, the order in the universe is a bit more restored now 😄

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 27, 2017

Member

Definitely agree with this.

For the record, we have gone back and forth with this one line a few times. Folks who can’t install without sudo insist it should be included. Then someone comes in later and insists sudo should never be used. I think High Sierra makes it moot on Mac but folks running system installations of Ruby may still need sudo.

Just raising awareness of the fact that this is not a “no brainer,” and that we have changed this line once a year for the last 4 years, back and forth.

Member

parkr commented Oct 27, 2017

Definitely agree with this.

For the record, we have gone back and forth with this one line a few times. Folks who can’t install without sudo insist it should be included. Then someone comes in later and insists sudo should never be used. I think High Sierra makes it moot on Mac but folks running system installations of Ruby may still need sudo.

Just raising awareness of the fact that this is not a “no brainer,” and that we have changed this line once a year for the last 4 years, back and forth.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 27, 2017

Member

On macOS High Sierra, with rbenv I never have to use sudo for those commands:

$ ruby -v
ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-darwin16]

$ gem update --system
Latest version currently installed. Aborting.

$ gem install jekyll
Successfully installed jekyll-3.6.2
1 gem installed

I'll happily add a section about installing Jekyll with brew and rbenv in the docs.

Member

DirtyF commented Oct 27, 2017

On macOS High Sierra, with rbenv I never have to use sudo for those commands:

$ ruby -v
ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-darwin16]

$ gem update --system
Latest version currently installed. Aborting.

$ gem install jekyll
Successfully installed jekyll-3.6.2
1 gem installed

I'll happily add a section about installing Jekyll with brew and rbenv in the docs.

@chrisfinazzo

This comment has been minimized.

Show comment
Hide comment
@chrisfinazzo

chrisfinazzo Oct 27, 2017

Contributor

@DirtyF, I've since forgotten - this isn't global, correct? I'm so tied into the Bundler way of thinking that I would be concerned about doing that. The exception I suppose being if you have many sites to manage and need the jekyll commands available from anywhere.

@andrewda, The whole "Bundler as a requirement" seems to be tied up in this discussion as well. This specific issue was first raised in #3999 and later #4368. I am of the opinion that we really should be encouraging people to adopt it.

@parkr Do we have any sense about how common this behavior is? It seems like Apple has clued into the fact that they were behind on shipping newer Ruby versions as the default (my system, on 10.12.6 has 2.4.x), but I would be concerned about upgrades if the environment changes as part of an upgrade.

Contributor

chrisfinazzo commented Oct 27, 2017

@DirtyF, I've since forgotten - this isn't global, correct? I'm so tied into the Bundler way of thinking that I would be concerned about doing that. The exception I suppose being if you have many sites to manage and need the jekyll commands available from anywhere.

@andrewda, The whole "Bundler as a requirement" seems to be tied up in this discussion as well. This specific issue was first raised in #3999 and later #4368. I am of the opinion that we really should be encouraging people to adopt it.

@parkr Do we have any sense about how common this behavior is? It seems like Apple has clued into the fact that they were behind on shipping newer Ruby versions as the default (my system, on 10.12.6 has 2.4.x), but I would be concerned about upgrades if the environment changes as part of an upgrade.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 27, 2017

Member

I am of the opinion that we really should be encouraging people to adopt it.

Bundler has been merged into standard Library in Ruby 2.5 preview 1.

Member

DirtyF commented Oct 27, 2017

I am of the opinion that we really should be encouraging people to adopt it.

Bundler has been merged into standard Library in Ruby 2.5 preview 1.

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Oct 28, 2017

Member

@jekyllbot: merge +docs

Member

mattr- commented Oct 28, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 1f8704f into jekyll:master Oct 28, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Oct 28, 2017

Member

@DirtyF whoops! I just noticed this was assigned to you. I didn't see any reason to not merge it, so I just went ahead and did it. Sorry. 🙈

Member

mattr- commented Oct 28, 2017

@DirtyF whoops! I just noticed this was assigned to you. I didn't see any reason to not merge it, so I just went ahead and did it. Sorry. 🙈

@andrewda andrewda deleted the andrewda:no-sudo branch Oct 28, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 29, 2017

Member

@mattr- I only assigned myself documentation issues to prevent stale, thanks for steppin' in ❤️

Member

DirtyF commented Oct 29, 2017

@mattr- I only assigned myself documentation issues to prevent stale, thanks for steppin' in ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment