New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated custom-404-page.md #6489

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
4 participants
@gurtjun
Contributor

gurtjun commented Oct 27, 2017

I'm not sure if I was doing something wrong or the docs are incorrect.
But the only way I managed to serve a custom 404 page was by adding an equality sign (=) to the location directive.

Please correct me if I'm wrong.

Updated custom-404-page.md
I'm not sure if I was doing something wrong or the docs are incorrect. 
But the only way I managed to serve a custom 404 page was by adding an equality sign (`=`) to the location directive.

Please correct me if I'm wrong.
@DirtyF

DirtyF approved these changes Oct 27, 2017

👍 For an exact location, = will be faster.
source: http://nginx.org/en/docs/http/ngx_http_core_module.html#location

@DirtyF DirtyF requested a review from jekyll/documentation Oct 27, 2017

@parkr

parkr approved these changes Oct 27, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 27, 2017

Member

Failure on Ruby 2.1 on Appveyor looks unrelated:

Failure:
TestRedcarpet#test_: redcarpet with pygments enabled should render fenced code blocks with syntax highlighting.  [C:/projects/jekyll/test/test_redcarpet.rb:49]
Minitest::Assertion: --- expected
+++ actual
@@ -1,2 +1 @@
-"<div class=\"highlight\"><pre><code class=\"language-ruby\" data-lang=\"ruby\"><span class=\"nb\">puts</span> <span class=\"s2\">"Hello world"</span>
-</code></pre></div>"
+""
Member

parkr commented Oct 27, 2017

Failure on Ruby 2.1 on Appveyor looks unrelated:

Failure:
TestRedcarpet#test_: redcarpet with pygments enabled should render fenced code blocks with syntax highlighting.  [C:/projects/jekyll/test/test_redcarpet.rb:49]
Minitest::Assertion: --- expected
+++ actual
@@ -1,2 +1 @@
-"<div class=\"highlight\"><pre><code class=\"language-ruby\" data-lang=\"ruby\"><span class=\"nb\">puts</span> <span class=\"s2\">"Hello world"</span>
-</code></pre></div>"
+""
@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 27, 2017

Member

@jekyllbot: merge +docs

🍻 for you first contribution @gurtjun 😄

Member

DirtyF commented Oct 27, 2017

@jekyllbot: merge +docs

🍻 for you first contribution @gurtjun 😄

@jekyllbot jekyllbot merged commit a4315fa into jekyll:master Oct 27, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gurtjun

This comment has been minimized.

Show comment
Hide comment
@gurtjun

gurtjun Oct 27, 2017

Contributor

Awesome, thanks guys! 😄

Contributor

gurtjun commented Oct 27, 2017

Awesome, thanks guys! 😄

@gurtjun gurtjun deleted the gurtjun:patch-1 branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment