New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update normalize.css to v7.0.0 #6491

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
7 participants
@chrisfinazzo
Contributor

chrisfinazzo commented Oct 27, 2017

No description provided.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 27, 2017

Member

I'm not sure we need all that is in Normalize (typically forms).

Is it worth taking a shot at Bootstrap's reboot and see how it behaves?

update: Reboot behaves differently, notably on headers margin.

Member

DirtyF commented Oct 27, 2017

I'm not sure we need all that is in Normalize (typically forms).

Is it worth taking a shot at Bootstrap's reboot and see how it behaves?

update: Reboot behaves differently, notably on headers margin.

@parkr

parkr approved these changes Oct 27, 2017

@chrisfinazzo

This comment has been minimized.

Show comment
Hide comment
@chrisfinazzo

chrisfinazzo Oct 27, 2017

Contributor

@DirtyF That's a fair point. Can you post a screenshot to show this?

I tried to verify this, but I think I may need to punt my current install and run script/bootstrap again. My personal site is only at 3.1 and I've got old versions of Ruby in there and a bunch of other stuff.

Time to start fresh I think.

New job on Monday, new Jekyll install...I'm sensing a pattern here 😄

Contributor

chrisfinazzo commented Oct 27, 2017

@DirtyF That's a fair point. Can you post a screenshot to show this?

I tried to verify this, but I think I may need to punt my current install and run script/bootstrap again. My personal site is only at 3.1 and I've got old versions of Ruby in there and a bunch of other stuff.

Time to start fresh I think.

New job on Monday, new Jekyll install...I'm sensing a pattern here 😄

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 27, 2017

Member

@chrisfinazzo Normalize still do the job, even with a few useless kilobytes.
You're free to revisit this in another PR if you're up to it 🖌

@jekyllbot: merge +site

Member

DirtyF commented Oct 27, 2017

@chrisfinazzo Normalize still do the job, even with a few useless kilobytes.
You're free to revisit this in another PR if you're up to it 🖌

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 39210d0 into jekyll:master Oct 27, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chrisfinazzo chrisfinazzo referenced this pull request Oct 28, 2017

Closed

Bundler versions #6492

6 of 6 tasks complete
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 30, 2017

Contributor

TBQF I think Jekyll should move to reset.css from Bootstrap, it's better.

Contributor

envygeeks commented Oct 30, 2017

TBQF I think Jekyll should move to reset.css from Bootstrap, it's better.

@chrisfinazzo chrisfinazzo referenced this pull request Jul 9, 2018

Closed

Reboot.css #7120

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment