New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Rubocop config #6495

Merged
merged 1 commit into from Oct 29, 2017

Conversation

Projects
None yet
6 participants
@ashmaroli
Member

ashmaroli commented Oct 29, 2017

  • enabling Style/Attr cop doesn't throw any offense on current codebase
  • Layout/SpaceAroundOperators and Style/FrozenStringLiteralComment cops are enabled by default

/cc @pathawks

clean up Rubocop config
  - enabling `Style/Attr` cop doesn't throw any offense on current codebase
  - `Layout/SpaceAroundOperators` and `Style/FrozenStringLiteralComment` cops are enabled by default
@DirtyF

DirtyF approved these changes Oct 29, 2017

@oe

oe approved these changes Oct 29, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 29, 2017

Member

What’s wrong with Travis?

Member

pathawks commented Oct 29, 2017

What’s wrong with Travis?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Oct 29, 2017

Member

What’s wrong with Travis?

Will be fixed with #6496

Member

ashmaroli commented Oct 29, 2017

What’s wrong with Travis?

Will be fixed with #6496

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Oct 29, 2017

Member

@jekyllbot: merge +dev

Member

mattr- commented Oct 29, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 0feccde into jekyll:master Oct 29, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ashmaroli ashmaroli deleted the ashmaroli:rubocop-config branch Oct 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment