New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to modify the obsolete files. #6502

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
6 participants
@envygeeks
Contributor

envygeeks commented Oct 30, 2017

No description provided.

@DirtyF DirtyF requested a review from jekyll/core Oct 30, 2017

@DirtyF DirtyF added the enhancement label Oct 30, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 30, 2017

Member

What is the use case here?

Member

DirtyF commented Oct 30, 2017

What is the use case here?

@oe

oe approved these changes Oct 30, 2017

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 30, 2017

Contributor

@DirtyF https://github.com/jekyll/jekyll-assets/blob/master/lib/jekyll/assets/patches/obsolete_files.rb should be unnecessary, people shouldn't have to hack Jekyll to prevent clobbering if their files at-large.

Contributor

envygeeks commented Oct 30, 2017

@DirtyF https://github.com/jekyll/jekyll-assets/blob/master/lib/jekyll/assets/patches/obsolete_files.rb should be unnecessary, people shouldn't have to hack Jekyll to prevent clobbering if their files at-large.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 30, 2017

Member

@envygeeks got you 👌

Member

DirtyF commented Oct 30, 2017

@envygeeks got you 👌

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 30, 2017

Member

@jekyllbot: merge +minor

Member

DirtyF commented Oct 30, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit aa959ce into jekyll:master Oct 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@DirtyF DirtyF added this to the v3.7.0 milestone Oct 30, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Oct 30, 2017

Member

Thanks @envygeeks. 👍

Member

DirtyF commented Oct 30, 2017

Thanks @envygeeks. 👍

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 30, 2017

Member

This should be documented on the plugins page.

Member

parkr commented Oct 30, 2017

This should be documented on the plugins page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment