New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kernel#Array instead of explicit Array check #6525

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Nov 6, 2017

Ref: bbatsov/ruby-style-guide
I don't think there's a cop for this yet.

Also, I guess its better handling such lines one-at-a-time..

@DirtyF

DirtyF approved these changes Nov 6, 2017

@DirtyF DirtyF added the internal label Nov 6, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 6, 2017

Member

A coP for this world be nice. Is there an open Rubocop issue to add this?

Member

pathawks commented Nov 6, 2017

A coP for this world be nice. Is there an open Rubocop issue to add this?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 6, 2017

Member

Is there an open Rubocop issue to add this?

None that I could pin-point on

Member

ashmaroli commented Nov 6, 2017

Is there an open Rubocop issue to add this?

None that I could pin-point on

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 6, 2017

Member

@jekyllbot: merge +dev

Member

DirtyF commented Nov 6, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 7690fcb into jekyll:master Nov 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:use-kernel-Array branch Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment