New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style mobile-docs select element #6545

Merged
merged 1 commit into from Nov 12, 2017

Conversation

Projects
None yet
5 participants
@ashmaroli
Member

ashmaroli commented Nov 12, 2017

localhost-4000-news

@ashmaroli ashmaroli added the site label Nov 12, 2017

@ashmaroli ashmaroli requested a review from DirtyF Nov 12, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 12, 2017

Member

Did you test on a phone?

My Androïd overrides the display of the options, so it's more usable on a phone.

Member

DirtyF commented Nov 12, 2017

Did you test on a phone?

My Androïd overrides the display of the options, so it's more usable on a phone.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 12, 2017

Member

Did you test on a phone?

yep.. tested on an android phone.. the styles for <option> are overridden by the user-agent's defaults..
this PR's styles will nevertheless act as placeholder for browsers that do not style the <option> elems..

I've published a temporary sample at https://ashmaroli.github.io/test-site/docs/home/ for easier testing..

Member

ashmaroli commented Nov 12, 2017

Did you test on a phone?

yep.. tested on an android phone.. the styles for <option> are overridden by the user-agent's defaults..
this PR's styles will nevertheless act as placeholder for browsers that do not style the <option> elems..

I've published a temporary sample at https://ashmaroli.github.io/test-site/docs/home/ for easier testing..

@parkr

Slick! I defer to @DirtyF &co.

@DirtyF

DirtyF approved these changes Nov 12, 2017

@Crunch09

👍 Nice!

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 12, 2017

Member

@jekyllbot: merge +site

Member

DirtyF commented Nov 12, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 77dd16a into jekyll:master Nov 12, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:mobile-docs-select branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment