New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock to cucumber 3.0.1 on Ruby 2.1 #6546

Merged
merged 3 commits into from Nov 12, 2017

Conversation

Projects
None yet
5 participants
@ashmaroli
Member

ashmaroli commented Nov 12, 2017

Cucumber 3.0.2 has dropped support for Ruby 2.1

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 12, 2017

Member

I"m all with @mattr and @pathawks we shouldn't patch to support an EOL Ruby version. Let's bump Jekyll to a major version and remove EOL Ruby dependencies.

Member

DirtyF commented Nov 12, 2017

I"m all with @mattr and @pathawks we shouldn't patch to support an EOL Ruby version. Let's bump Jekyll to a major version and remove EOL Ruby dependencies.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 12, 2017

Member

By the end of March 2018, even 2.2 will go EOL.. so I think its best we put off 4.0 till dependencies start to drop support for Ruby 2.2 as well.. or latest by May 2018..

Member

ashmaroli commented Nov 12, 2017

By the end of March 2018, even 2.2 will go EOL.. so I think its best we put off 4.0 till dependencies start to drop support for Ruby 2.2 as well.. or latest by May 2018..

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 12, 2017

Member

Cucumber is just a dev dependency.. much like nokogiri

jekyll/Gemfile

Line 30 in 9c7ef8f

gem "nokogiri", RUBY_VERSION >= "2.2" ? "~> 1.7" : "~> 1.7.0"

Member

ashmaroli commented Nov 12, 2017

Cucumber is just a dev dependency.. much like nokogiri

jekyll/Gemfile

Line 30 in 9c7ef8f

gem "nokogiri", RUBY_VERSION >= "2.2" ? "~> 1.7" : "~> 1.7.0"

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 12, 2017

Member

Cucumber is just a dev dependency.. much like nokogiri

So why do we need to lock the dev dependencies to Ruby < 2.2 exactly? (pardon my ignorance)

Member

DirtyF commented Nov 12, 2017

Cucumber is just a dev dependency.. much like nokogiri

So why do we need to lock the dev dependencies to Ruby < 2.2 exactly? (pardon my ignorance)

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 12, 2017

Member

So why do we need to lock the dev dependencies to Ruby < 2.2 exactly? (pardon my ignorance)

so that our CI continues as usual, till the library code drops support for EOL ruby versions..

Member

ashmaroli commented Nov 12, 2017

So why do we need to lock the dev dependencies to Ruby < 2.2 exactly? (pardon my ignorance)

so that our CI continues as usual, till the library code drops support for EOL ruby versions..

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 12, 2017

Member

By the end of March 2018, even 2.2 will go EOL

Let's just say that 4.0 only supports >= 2.3, no matter when we release it. Problem solved.

Member

pathawks commented Nov 12, 2017

By the end of March 2018, even 2.2 will go EOL

Let's just say that 4.0 only supports >= 2.3, no matter when we release it. Problem solved.

@parkr

parkr approved these changes Nov 12, 2017

This is a good patch for now.

Regarding 4.0, is there a plan? Maybe write up a document as a PR with specific goals?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 12, 2017

Member

@jekyllbot: merge +dev

Member

DirtyF commented Nov 12, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 9b044b9 into jekyll:master Nov 12, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ashmaroli ashmaroli deleted the ashmaroli:cucumber-21 branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment