New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json extension to list of directory indices #6550

Merged
merged 3 commits into from Nov 13, 2017

Conversation

Projects
None yet
6 participants
@adborden
Contributor

adborden commented Nov 13, 2017

Fixes #6348

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 13, 2017

Member

Now Rubocop says webrick_opts has too many lines. 🙃

Member

pathawks commented Nov 13, 2017

Now Rubocop says webrick_opts has too many lines. 🙃

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 13, 2017

Member

one way out is to move the entire array to a class constant or a new private method if that's better..
the other obvious way is to have two files per line.. 😄

            :DirectoryIndex     => %w(
              index.htm index.html
              index.rhtml index.cgi
              index.xml index.json
            ),
Member

ashmaroli commented Nov 13, 2017

one way out is to move the entire array to a class constant or a new private method if that's better..
the other obvious way is to have two files per line.. 😄

            :DirectoryIndex     => %w(
              index.htm index.html
              index.rhtml index.cgi
              index.xml index.json
            ),
@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 13, 2017

Member

move the entire array to a class constant

👍

Member

pathawks commented Nov 13, 2017

move the entire array to a class constant

👍

@parkr

parkr approved these changes Nov 13, 2017

👍 on content – I'll let Rubocop dictate the style. 😄

adborden and others added some commits Nov 13, 2017

Move directory index array to class constant
Rubocop says webrick_opts has too many lines, this reduces the line count for
the method.
@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 13, 2017

Member

@adborden Thanks for this excellent first contrib! ❤️

@jekyllbot: merge +minor

Member

DirtyF commented Nov 13, 2017

@adborden Thanks for this excellent first contrib! ❤️

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 707a8c7 into jekyll:master Nov 13, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@DirtyF DirtyF added this to the v3.7.0 milestone Nov 13, 2017

@adborden adborden deleted the adborden:feature/json-directory-index branch Nov 13, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 13, 2017

Member

Woohoo! Well done

Member

parkr commented Nov 13, 2017

Woohoo! Well done

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 16, 2017

Member

@adborden This has shipped on GitHub Pages and will roll out to 100% of sites over the next few hours.

Member

parkr commented Nov 16, 2017

@adborden This has shipped on GitHub Pages and will roll out to 100% of sites over the next few hours.

@adborden

This comment has been minimized.

Show comment
Hide comment
@adborden

adborden Nov 17, 2017

Contributor
Contributor

adborden commented Nov 17, 2017

DirtyF added a commit that referenced this pull request Dec 7, 2017

DirtyF added a commit that referenced this pull request Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment