New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site: Search with DocSearch by @Algolia #6557

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
5 participants
@jekyllbot
Contributor

jekyllbot commented Nov 14, 2017

Fix #6508

This PR add search to Jekyll's website thanks to @algolia's DocSearch

Configuration is versioned on Algolia's repository

Show outdated Hide outdated docs/latest_version.txt Outdated
Show outdated Hide outdated docs/_sass/_docsearch.scss Outdated
@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Nov 14, 2017

Member

@DirtyF any way to vertically align the search bar with the other menu items?

image

Member

oe commented Nov 14, 2017

@DirtyF any way to vertically align the search bar with the other menu items?

image

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Nov 14, 2017

Member

also, this 🤔

image

Member

oe commented Nov 14, 2017

also, this 🤔

image

@@ -0,0 +1 @@
<input type="text" id="docsearch-input" placeholder="Search the docs…">

This comment has been minimized.

@oe

oe Nov 14, 2017

Member

is there any usecase for including this somewhere else?

@oe

oe Nov 14, 2017

Member

is there any usecase for including this somewhere else?

This comment has been minimized.

@DirtyF

DirtyF Nov 14, 2017

Member

I just wanted to isolate the search component in its own file, like I did for JS and CSS.

@DirtyF

DirtyF Nov 14, 2017

Member

I just wanted to isolate the search component in its own file, like I did for JS and CSS.

@DirtyF DirtyF changed the title from Site: Search with DocSearch by @Algolia to Site: Search with DocSearch by @Algolia (wip) Nov 14, 2017

@DirtyF DirtyF self-assigned this Nov 14, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 14, 2017

Member

@pup fixed thanks to @s-pace in algolia/docsearch-configs@9f0d791 🔧

capture d ecran 2017-11-14 20 12 35

🎉

Member

DirtyF commented Nov 14, 2017

@pup fixed thanks to @s-pace in algolia/docsearch-configs@9f0d791 🔧

capture d ecran 2017-11-14 20 12 35

🎉

@s-pace

This comment has been minimized.

Show comment
Hide comment
@s-pace

s-pace Nov 14, 2017

Feel free to ping us.
Would be glad to help you and enhance this search experience!
Well done, thanks @DirtyF

s-pace commented Nov 14, 2017

Feel free to ping us.
Would be glad to help you and enhance this search experience!
Well done, thanks @DirtyF

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 14, 2017

Member

@pup fixed the positioning

search-position

Member

DirtyF commented Nov 14, 2017

@pup fixed the positioning

search-position

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 14, 2017

Member

Styles are OK now

jekyll-search

Member

DirtyF commented Nov 14, 2017

Styles are OK now

jekyll-search

@DirtyF DirtyF changed the title from Site: Search with DocSearch by @Algolia (wip) to Site: Search with DocSearch by @Algolia Nov 14, 2017

@DirtyF DirtyF added this to the v3.7.0 milestone Nov 14, 2017

@DirtyF DirtyF requested a review from parkr Nov 14, 2017

font-size: 1rem;
text-shadow: none;
.ds-suggestion.ds-cursor .algolia-docsearch-suggestion:not(.suggestion-layout-simple) .algolia-docsearch-suggestion--content {

This comment has been minimized.

@ashmaroli

ashmaroli Nov 15, 2017

Member

I guess this line can be shortened by further nesting.. no? 😃

@ashmaroli

ashmaroli Nov 15, 2017

Member

I guess this line can be shortened by further nesting.. no? 😃

@oe

oe approved these changes Nov 15, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 15, 2017

Member

Let's get this live and see how it behaves. We mostly need feedback from users.

@jekyllbot: merge +site

Member

DirtyF commented Nov 15, 2017

Let's get this live and see how it behaves. We mostly need feedback from users.

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 9431fdb into master Nov 15, 2017

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/docsearch-algolia branch Nov 15, 2017

@s-pace

This comment has been minimized.

Show comment
Hide comment
@s-pace

s-pace Nov 15, 2017

Regarding those feedbacks, I have granted @DirtyF to the feedback we have from your search bar.

Feel free to ask me to add other people by sending me the email address.

Congrats

s-pace commented Nov 15, 2017

Regarding those feedbacks, I have granted @DirtyF to the feedback we have from your search bar.

Feel free to ask me to add other people by sending me the email address.

Congrats

DirtyF added a commit that referenced this pull request Dec 7, 2017

Site: Search with @algolia DocSearch (#6557)
Merge pull request 6557

DirtyF added a commit that referenced this pull request Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment