New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid block parser warning in SmartyPants #6565

Merged
merged 4 commits into from Nov 17, 2017

Conversation

Projects
None yet
5 participants
@jekyllbot
Contributor

jekyllbot commented Nov 16, 2017

PR automatically created for @pathawks.

Avoid block parser warning

@pathawks pathawks changed the title from Avoid block parser warning to Avoid block parser warning in SmartyPants Nov 16, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 16, 2017

Member

Huge thanks to @gettalong who wrote the fix for this ❤️🍻

/cc: @jekyll/build

Member

pathawks commented Nov 16, 2017

Huge thanks to @gettalong who wrote the fix for this ❤️🍻

/cc: @jekyll/build

@pathawks pathawks requested review from DirtyF and Crunch09 Nov 16, 2017

pathawks added some commits Nov 16, 2017

@DirtyF

DirtyF approved these changes Nov 16, 2017

LGTM. No more warnings on Jekyll's website.

@DirtyF DirtyF added this to the v3.7.0 milestone Nov 16, 2017

@ashmaroli

a few inconsistencies..

Show outdated Hide outdated lib/jekyll/converters/smartypants.rb Outdated
Show outdated Hide outdated lib/jekyll/converters/smartypants.rb Outdated

I have made changes. Please re-review 👍

Show outdated Hide outdated test/test_filters.rb Outdated
@ashmaroli

LGTM! 👍

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 17, 2017

Member

@jekyllbot: merge +bug

Member

pathawks commented Nov 17, 2017

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 2c646a3 into master Nov 17, 2017

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Nov 17, 2017

@jekyllbot jekyllbot deleted the pull/fix-smartypants branch Nov 17, 2017

DirtyF added a commit that referenced this pull request Dec 7, 2017

DirtyF added a commit that referenced this pull request Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment