New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logo above site navigation on small screens #6570

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Nov 20, 2017

Current layout

localhost_4000_ logo-below

Proposed layout

localhost_4000_logo-above

@ashmaroli ashmaroli added the site label Nov 20, 2017

@ashmaroli ashmaroli requested a review from DirtyF Nov 20, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 20, 2017

Member

The most significant update here would be to stick the navigation on the bottom on mobile, because we use our thumbs to tap and it's hard to reach the top of the screen.

image

Member

DirtyF commented Nov 20, 2017

The most significant update here would be to stick the navigation on the bottom on mobile, because we use our thumbs to tap and it's hard to reach the top of the screen.

image

@DirtyF

DirtyF approved these changes Nov 20, 2017

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 20, 2017

Member

update here would be to stick the navigation on the bottom on mobile

I agree on this, even though the examples you posted above are of native apps and ours is a website.. 😃

Member

ashmaroli commented Nov 20, 2017

update here would be to stick the navigation on the bottom on mobile

I agree on this, even though the examples you posted above are of native apps and ours is a website.. 😃

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 20, 2017

Member

There's no such things as native apps or websites for our thumbs, I should have posted black screen instead

image

source: https://www.lukew.com/ff/entry.asp?1944

Member

DirtyF commented Nov 20, 2017

There's no such things as native apps or websites for our thumbs, I should have posted black screen instead

image

source: https://www.lukew.com/ff/entry.asp?1944

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 20, 2017

Member

@jekyllbot: merge +site

Member

DirtyF commented Nov 20, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit e88b813 into jekyll:master Nov 20, 2017

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:mobile-docs-header branch Nov 20, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 20, 2017

Member

I don’t think the nav bar should be always visible at the bottom of the screen. Those buttons will not be frequently used–maybe once or twice each session. Making them always visible seems to give them too much prominence.

Member

pathawks commented Nov 20, 2017

I don’t think the nav bar should be always visible at the bottom of the screen. Those buttons will not be frequently used–maybe once or twice each session. Making them always visible seems to give them too much prominence.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 20, 2017

Member

we can always have a copy of the navbar at the bottom of the page.. then its upto the user to either scroll up or down to a navbar, whichever is nearer..

Member

ashmaroli commented Nov 20, 2017

we can always have a copy of the navbar at the bottom of the page.. then its upto the user to either scroll up or down to a navbar, whichever is nearer..

DirtyF added a commit that referenced this pull request Dec 7, 2017

DirtyF added a commit that referenced this pull request Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment