New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Include version badge for latest features #6574

Merged
merged 3 commits into from Nov 24, 2017

Conversation

Projects
None yet
5 participants
@jekyllbot
Contributor

jekyllbot commented Nov 23, 2017

PR automatically created for @DirtyF.

Docs: Include version badge for latest features

Fix #6568

Example:

docs-version-badge

This has to be done manually for each new feature of the current or upcoming minor version.
We could also tag the features from the previous minor version.

Ideally a user could browse the documentation of a specific version without having to install jekyll-docs gem.

@DirtyF DirtyF changed the title from Docs: Include version badge for latest features Fix #6568 to Docs: Include version badge for latest features Nov 23, 2017

@DirtyF DirtyF requested a review from jekyll/documentation Nov 23, 2017

@DirtyF DirtyF added this to the v3.7.0 milestone Nov 23, 2017

@parkr

parkr approved these changes Nov 24, 2017

We also have a class or two for pre-release callouts in the CSS (or we did). This looks great.

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Nov 24, 2017

Member

maybe vertically center the badge?

Member

oe commented Nov 24, 2017

maybe vertically center the badge?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 24, 2017

Member

@parkr Correct, and I made sure we can use a version badge in any type of note:

version-badges

@pup The badge is now vertically aligned 😸

Member

DirtyF commented Nov 24, 2017

@parkr Correct, and I made sure we can use a version badge in any type of note:

version-badges

@pup The badge is now vertically aligned 😸

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 24, 2017

Member

@jekyllbot: merge +site

Member

DirtyF commented Nov 24, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 46b2501 into master Nov 24, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP ready for review
Details

@jekyllbot jekyllbot deleted the pull/docs-version-badge branch Nov 24, 2017

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 24, 2017

Member

Nicely done @DirtyF 👏

Member

ashmaroli commented Nov 24, 2017

Nicely done @DirtyF 👏

DirtyF added a commit that referenced this pull request Dec 7, 2017

DirtyF added a commit that referenced this pull request Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment