New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop forwarding to private methods by exposing those methods as public #6577

Merged
merged 1 commit into from Nov 26, 2017

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Nov 26, 2017

Fixes #6382

Redefine private methods as public methods to prevent warning messages from the Ruby Interpreter since forwarding to private methods have been deprecated from Ruby 2.4

drop forwarding to private methods
redefine private methods as public methods to prevent warning messages
from the Ruby Interpreter since forwarding to private methods have been
deprecated from Ruby 2.4

@ashmaroli ashmaroli added this to the v3.7.0 milestone Nov 26, 2017

@oe

oe approved these changes Nov 26, 2017

@DirtyF

DirtyF approved these changes Nov 26, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 26, 2017

Member

@jekyllbot: merge +dev

Member

DirtyF commented Nov 26, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 0b4f657 into jekyll:master Nov 26, 2017

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:private-to-public branch Nov 27, 2017

DirtyF added a commit that referenced this pull request Dec 7, 2017

drop forwarding to private methods (#6577)
Merge pull request 6577

DirtyF added a commit that referenced this pull request Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment