New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup test_redcarpet.rb #6584

Merged
merged 1 commit into from Nov 29, 2017

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Nov 29, 2017

  • replace multiple calls to creating heredocs containing the same content, with an instance variable
  • use %() to wrap strings containing double quotes to avoid having to escape internal double-quotes, thereby improving readability at the minor expense of multiple string concatenation.

@ashmaroli ashmaroli added the tests label Nov 29, 2017

@DirtyF DirtyF added the internal label Nov 29, 2017

@DirtyF

DirtyF approved these changes Nov 29, 2017

@oe

oe approved these changes Nov 29, 2017

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Nov 29, 2017

Member

@jekyllbot: merge +dev

Member

oe commented Nov 29, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit da0df22 into jekyll:master Nov 29, 2017

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

DirtyF added a commit that referenced this pull request Dec 7, 2017

cleanup test_redcarpet.rb (#6584)
Merge pull request 6584

DirtyF added a commit that referenced this pull request Dec 7, 2017

@ashmaroli ashmaroli deleted the ashmaroli:test-cleanup branch Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment