New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register reload hooks in Server#process #6605

Merged
merged 2 commits into from Dec 15, 2017

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Dec 7, 2017

Resolves issue mention in #5142 (comment)

Calling :register_reload_hooks in #process after the site starts to generate... instead of much earlier in the build-process..

/cc @awood

@ashmaroli ashmaroli added the fix label Dec 7, 2017

@ashmaroli ashmaroli requested a review from DirtyF Dec 7, 2017

@DirtyF DirtyF requested a review from jekyll/build Dec 7, 2017

@DirtyF

It works 👍

port is displayed only if I had "livereload_port" => 35_729,, shouldn't it by the default?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Dec 7, 2017

Member

port is displayed only if..

I see the following with just bundle exec jekyll s --livereload and I feel its adequate.. though it would be better if the http:// protocol was included as well..

LiveReload address: 127.0.0.1:35729
    Server address: http://127.0.0.1:4000/
Member

ashmaroli commented Dec 7, 2017

port is displayed only if..

I see the following with just bundle exec jekyll s --livereload and I feel its adequate.. though it would be better if the http:// protocol was included as well..

LiveReload address: 127.0.0.1:35729
    Server address: http://127.0.0.1:4000/
@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Dec 7, 2017

Member

@ashmaroli The port is displayed if you pass the --livereload option on the CLI but not if you only pass the livereload option to the options hash and then call Jekyll::Commands::Serve.process(options) (in a rake task for example). You also have to specify livereload_port.

Member

DirtyF commented Dec 7, 2017

@ashmaroli The port is displayed if you pass the --livereload option on the CLI but not if you only pass the livereload option to the options hash and then call Jekyll::Commands::Serve.process(options) (in a rake task for example). You also have to specify livereload_port.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Dec 7, 2017

Member

I see.. I was running bundle exec jekyll s from within the docs/ folder..
FWIW, the LiveReload address: 127.0.0.1:35729 message appears when I serve the docs/ folder with livereload: true in ./docs/_config.yml

Member

ashmaroli commented Dec 7, 2017

I see.. I was running bundle exec jekyll s from within the docs/ folder..
FWIW, the LiveReload address: 127.0.0.1:35729 message appears when I serve the docs/ folder with livereload: true in ./docs/_config.yml

@ashmaroli ashmaroli added this to the v3.7.0 milestone Dec 7, 2017

@awood

This comment has been minimized.

Show comment
Hide comment
@awood

awood Dec 7, 2017

Contributor

@ashmaroli Thanks for fixing this so quickly.

Contributor

awood commented Dec 7, 2017

@ashmaroli Thanks for fixing this so quickly.

@DirtyF

DirtyF approved these changes Dec 7, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Dec 15, 2017

Member

@jekyllbot: merge +fix

Member

DirtyF commented Dec 15, 2017

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 1082a39 into jekyll:master Dec 15, 2017

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Dec 15, 2017

@ashmaroli ashmaroli deleted the ashmaroli:reload-patch branch Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment