New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove paginate check #6606

Merged
merged 4 commits into from Dec 10, 2017

Conversation

Projects
None yet
6 participants
@jekyllbot
Contributor

jekyllbot commented Dec 7, 2017

Fix #6391

@DirtyF DirtyF requested a review from jekyll/stability Dec 7, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF
Member

DirtyF commented Dec 7, 2017

/cc @sverrirs

@oe

oe approved these changes Dec 7, 2017

Show outdated Hide outdated lib/jekyll/configuration.rb Outdated
@@ -20,15 +20,6 @@ class TestConfiguration < JekyllUnitTest
assert_equal result["source"], "blah"
end
should "fix common mistakes" do

This comment has been minimized.

@parkr

parkr Dec 8, 2017

Member

Just have a test here to ensure it's there and returns a valid Configuration instance.

@parkr

parkr Dec 8, 2017

Member

Just have a test here to ensure it's there and returns a valid Configuration instance.

@pathawks pathawks removed this from the 4.0 milestone Dec 8, 2017

@parkr

parkr approved these changes Dec 9, 2017

One more, then good to go!

Show outdated Hide outdated test/test_configuration.rb Outdated

@ashmaroli ashmaroli added this to the v3.7.0 milestone Dec 10, 2017

Show outdated Hide outdated test/test_configuration.rb Outdated
Ensure retro-compatibility
fix_common_issues should still return a valid configuration
@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Dec 10, 2017

Member

@jekyllbot: merge +minor

Member

DirtyF commented Dec 10, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit ba75c87 into master Dec 10, 2017

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/pagination-check branch Dec 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment