New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `require_relative` to load Jekyll classes #6609

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
5 participants

@ashmaroli ashmaroli added the internal label Dec 8, 2017

@ashmaroli ashmaroli requested a review from pathawks Dec 8, 2017

@DirtyF DirtyF requested a review from benbalter Dec 8, 2017

@pathawks

I’m not sure why we weren’t doing this already 👍

I wonder if there are any other places where we are loading internal stuff with require rather than require_relative

@ashmaroli ashmaroli added this to the v3.7.0 milestone Dec 15, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Dec 15, 2017

Member

@jekyllbot: merge +fix

Member

DirtyF commented Dec 15, 2017

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 1971ddd into jekyll:master Dec 15, 2017

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Dec 15, 2017

@ashmaroli ashmaroli deleted the ashmaroli:require-relative-not-require branch Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment