New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default time zone depends upon server #6617

Merged
merged 2 commits into from Dec 10, 2017

Conversation

Projects
None yet
5 participants
@mittalyashu
Contributor

mittalyashu commented Dec 9, 2017

@@ -108,7 +108,7 @@ class="flag">flags</code> (specified on the command-line) that control them.
<a href="https://en.wikipedia.org/wiki/Tz_database">IANA Time Zone
Database</a> is valid, e.g. <code>America/New_York</code>. A list of all
available values can be found <a href="https://en.wikipedia.org/wiki/List_of_tz_database_time_zones">
here</a>. The default is the local time zone, as set by your operating system.

This comment has been minimized.

@ashmaroli

ashmaroli Dec 9, 2017

Member

This information is not wrong. So you should not be changing it.. instead:

When serving locally, the default is the local time zone, as set by your operating system.
But when served on a remote host, the default time zone depends on the server's setting
or location.
@ashmaroli

ashmaroli Dec 9, 2017

Member

This information is not wrong. So you should not be changing it.. instead:

When serving locally, the default is the local time zone, as set by your operating system.
But when served on a remote host, the default time zone depends on the server's setting
or location.

This comment has been minimized.

@mittalyashu

mittalyashu Dec 9, 2017

Contributor

Yup, you are right @ashmaroli. What about this?

When serving on a local machine, the default time zone is set by your operating system. But when served on a remote host/server, the default time zone depends on the server's setting or location.
@mittalyashu

mittalyashu Dec 9, 2017

Contributor

Yup, you are right @ashmaroli. What about this?

When serving on a local machine, the default time zone is set by your operating system. But when served on a remote host/server, the default time zone depends on the server's setting or location.

This comment has been minimized.

@ashmaroli

ashmaroli Dec 9, 2017

Member

fine as well..

@ashmaroli

ashmaroli Dec 9, 2017

Member

fine as well..

This comment has been minimized.

@mittalyashu

mittalyashu Dec 10, 2017

Contributor

Great

@mittalyashu

mittalyashu Dec 10, 2017

Contributor

Great

@ashmaroli ashmaroli requested a review from DirtyF Dec 9, 2017

@DirtyF

Thanks for the edit, please consider both local and remote situations

@mittalyashu

This comment has been minimized.

Show comment
Hide comment
@mittalyashu

mittalyashu Dec 10, 2017

Contributor

@DirtyF. Now you can merge the pull request.

Contributor

mittalyashu commented Dec 10, 2017

@DirtyF. Now you can merge the pull request.

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Dec 10, 2017

Member

We should explain the potential impact of a different location, .e.g. :

The local time zone is set by the operating system and may differ between your local machine and the remote server depending on its location.

Member

DirtyF commented Dec 10, 2017

We should explain the potential impact of a different location, .e.g. :

The local time zone is set by the operating system and may differ between your local machine and the remote server depending on its location.

@mittalyashu

This comment has been minimized.

Show comment
Hide comment
@mittalyashu

mittalyashu Dec 10, 2017

Contributor

What do you mean by potential impact?

and you have mentioned this

time zone is set by the operating system and can differ between your local machine and the remote server depending on its location.

Timezone cannot always be different from the operating system and remote server. Maybe a person is living in the same location where server is location (this could be a possibility).

But this line explains

When serving on a local machine, the default time zone is set by your operating system. But when served on a remote host/server, the default time zone depends on the server's setting or location.

If you have not set any timezone then what will be the timezone on your local machine and on the server.

Contributor

mittalyashu commented Dec 10, 2017

What do you mean by potential impact?

and you have mentioned this

time zone is set by the operating system and can differ between your local machine and the remote server depending on its location.

Timezone cannot always be different from the operating system and remote server. Maybe a person is living in the same location where server is location (this could be a possibility).

But this line explains

When serving on a local machine, the default time zone is set by your operating system. But when served on a remote host/server, the default time zone depends on the server's setting or location.

If you have not set any timezone then what will be the timezone on your local machine and on the server.

@DirtyF

DirtyF approved these changes Dec 10, 2017

@oe

oe approved these changes Dec 10, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Dec 10, 2017

Member

@jekyllbot: merge +docs

Member

DirtyF commented Dec 10, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit f9044ac into jekyll:master Dec 10, 2017

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Dec 10, 2017

Member

@mittalyashu Thanks for this first contribution.

Member

DirtyF commented Dec 10, 2017

@mittalyashu Thanks for this first contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment