New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to an actively-maintained TOML parser. #6652

Merged
merged 1 commit into from Jan 2, 2018

Conversation

Projects
None yet
5 participants
@jashank
Contributor

jashank commented Dec 27, 2017

We have an ancient version of the toml gem which appears to have been abandoned for years and isn't compliant with TOML 0.4.0, the current state of the art.

The tomlrb and toml-rb gems are both (more) actively maintained and kept up-to-date; switching to either gives us TOML 0.4.0 support. This patch switches us to tomlrb.

(See also: #6540 #6541)

Switch to an actively-maintained TOML parser.
We have an ancient version of the `toml` gem which appears to have
been abandoned for years and isn't compliant with TOML 0.4.0, the
current state of the art.

The `tomlrb` and `toml-rb` gems are both (more) actively maintained
and kept up-to-date; switching to either gives us TOML 0.4.0 support.
This patch switches us to `tomlrb`.

(See also: #6540 #6541)
@jashank

This comment has been minimized.

Show comment
Hide comment
@jashank

jashank Dec 27, 2017

Contributor

Whoops! I didn't notice the tests; amended.

Contributor

jashank commented Dec 27, 2017

Whoops! I didn't notice the tests; amended.

@DirtyF

DirtyF approved these changes Dec 27, 2017

@DirtyF DirtyF requested a review from jekyll/stability Dec 27, 2017

@DirtyF DirtyF added the dependency label Dec 27, 2017

@oe

oe approved these changes Dec 27, 2017 edited

afaik toml 0.4 is backwards-incompatible in some ways, right?

@oe oe added this to the 4.0 milestone Dec 27, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 2, 2018

Member

Hm, looks fine to me: https://github.com/toml-lang/toml/releases

We don't do much with TOML ourselves so I'd say this can go into 3.7.0.

Member

parkr commented Jan 2, 2018

Hm, looks fine to me: https://github.com/toml-lang/toml/releases

We don't do much with TOML ourselves so I'd say this can go into 3.7.0.

@oe oe modified the milestones: 4.0, v3.7.0 Jan 2, 2018

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Jan 2, 2018

Member

@parkr okay!

@jekyllbot: merge +minor

Member

oe commented Jan 2, 2018

@parkr okay!

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit a9fe568 into jekyll:master Jan 2, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment