New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test against Ruby 2.5.0 #6664

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
5 participants
@jekyllbot
Contributor

jekyllbot commented Jan 3, 2018

  • Test against Ruby 2.5.0
  • Stop testing against Ruby 2.1 (EOL)

@DirtyF DirtyF requested a review from jekyll/administrators Jan 3, 2018

@DirtyF DirtyF added the tests label Jan 3, 2018

@ashmaroli

might as well bump all ruby versions in the matrix..

.travis.yml Outdated
- &ruby1 2.5.0
- &ruby2 2.4.2
- &ruby4 2.3.5
- &ruby4 2.2.8

This comment has been minimized.

@ashmaroli

ashmaroli Jan 3, 2018

Member

duplicate assignment:

&ruby4 2.3.5
&ruby4 2.2.8

This comment has been minimized.

@DirtyF

DirtyF Jan 3, 2018

Member

fixed

@parkr

Great!!

We test Rouge 1.11 twice. Can you please remove the one which specifies the TEST_SUITE and just leave the second one?

@ashmaroli

JRuby is now at 9.1.15.0..
And looks like we'll have to drop Cucumber tests for Ruby 2.1 to have Travis go Green again..

@parkr

It’s fully duplicate so you can remove that part of the matrix entirely.

.travis.yml Outdated
- &jruby jruby-9.1.14.0
matrix:
include:
- rvm: *ruby1
env: TEST_SUITE=test ROUGE=1.11.1
env: TEST_SUITE=test

This comment has been minimized.

@parkr

parkr Jan 3, 2018

Member

Just remove this section entirely including rvm above.

@DirtyF

This comment has been minimized.

Member

DirtyF commented Jan 3, 2018

Travis is green again 💚

@parkr

This comment has been minimized.

Member

parkr commented Jan 4, 2018

@DirtyF out of curiosity, why did you remove the more specific versions? Using the most up-to-date versions seems like a good idea?

@DirtyF

This comment has been minimized.

Member

DirtyF commented Jan 4, 2018

@parkr I don't remember CI failing because of an updated patched version of Ruby, added the specificity back with latest versions, travis is still green 💚

@parkr

parkr approved these changes Jan 4, 2018

Thank you!

@ashmaroli

@Crunch09

🆕

@parkr

This comment has been minimized.

Member

parkr commented Jan 5, 2018

I guess we also need to remove 2.1 on AppVeyor?

@parkr

This comment has been minimized.

Member

parkr commented Jan 5, 2018

Or we set jekyll-watch to 1.x when Ruby 2.1 or below!

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Jan 5, 2018

Or we set jekyll-watch to 1.x when Ruby 2.1 or below!

We haven't received any complaints of recent releases of jekyll-watch breaking an existing workflows.. ergo its safe to assume that Jekyll users still on Ruby 2.1 are fine with having to upgrade their Ruby Version..

So, lets drop testing on Ruby 2.1 its EOL anyways..

@parkr

This comment has been minimized.

Member

parkr commented Jan 5, 2018

👍 to dropping a potentially unsafe version of Ruby. Can happen in another PR.

@DirtyF

This comment has been minimized.

Member

DirtyF commented Jan 5, 2018

#6560 drops support of Ruby 2.1 and 2.2

@parkr

This comment has been minimized.

Member

parkr commented Jan 5, 2018

#6640 adds dependency update checks to jekyll doctor. I don’t see a PR which removes 2.1. You can add it here too.

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Jan 5, 2018

#6640 drops support of Ruby 2.1 and 2.2

I think you pointed towards the wrong PR.. Either ways, existing PRs propose dropping library support for older Rubies entirely.. I was suggesting just stop testing on outdated Ruby versions..

@DirtyF

This comment has been minimized.

Member

DirtyF commented Jan 5, 2018

I meant #6560

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Jan 5, 2018

please drop 2.1 on AppVeyor too..

CI: Test against Ruby 2.5.0
- Test against latest patched versions
- Remove duplicate Rouge 1.x testing
- Stop testing EOL Ruby 2.1
@parkr

This comment has been minimized.

Member

parkr commented Jan 5, 2018

Definitely remove Ruby 2.1, but 2.2 is still in security maintenance. https://www.ruby-lang.org/en/downloads/branches/

Let’s remove 2.1 in this PR.

@parkr

This comment has been minimized.

Member

parkr commented Jan 5, 2018

Feel free to merge once Travis & AppVeyor are both 💚

@DirtyF

This comment has been minimized.

Member

DirtyF commented Jan 5, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit c96289f into master Jan 5, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/test-ruby-2.5.0 branch Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment