New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add note about posts in context of collections_dir #6680

Merged
merged 1 commit into from Jan 7, 2018

Conversation

Projects
None yet
5 participants
@localheinz
Contributor

localheinz commented Jan 7, 2018

This PR

  • adds a warning about the _posts directory in the context of specifying a custom collections_dir

Follows #6331.
Related to #6678.
Follows #6679 (comment).

screen shot 2018-01-07 at 12 18 53

<p>Then Jekyll will look in <code>my_collections/_books</code> for the <code>books</code> collection, and
in <code>my_collections/_recipes</code> for the <code>recipes</code> collection.</p>
in <code>my_collections/_recipes</code> for the <code>recipes</code> collection. Since posts and drafts are collections as well, you will need to move the <code>_drafts</code> and <code>_posts</code> directories into <code>my_collections</code> as well.</p>

This comment has been minimized.

@localheinz

localheinz Jan 7, 2018

Contributor

Should we turn this into a warning?

This comment has been minimized.

@ashmaroli

ashmaroli Jan 7, 2018

Member

drafts are not a collection! They're just a temporary holding..

This comment has been minimized.

@ashmaroli

ashmaroli Jan 7, 2018

Member

I've updated my previous PR to confirm that drafts at the root are processed even when a custom collections_dir is set..

This comment has been minimized.

@localheinz

localheinz Jan 7, 2018

Contributor

@ashmaroli

How about the issue, though, that when you have collections in a custom collections directory and posts at the root, that the posts will have a draft status (regardless of whether publishing date is in the past or not)?

Ha, never mind.

@localheinz localheinz changed the title from Fix: Add note about posts in context of collections_dir to Fix: Add note about drafts and posts in context of collections_dir Jan 7, 2018

<p>Then Jekyll will look in <code>my_collections/_books</code> for the <code>books</code> collection, and
in <code>my_collections/_recipes</code> for the <code>recipes</code> collection.</p>
in <code>my_collections/_recipes</code> for the <code>recipes</code> collection. Since posts and drafts are collections as well, you will need to move the <code>_drafts</code> and <code>_posts</code> directories into <code>my_collections</code> as well.</p>

This comment has been minimized.

@ashmaroli

ashmaroli Jan 7, 2018

Member

drafts are not a collection! They're just a temporary holding..

@localheinz localheinz changed the title from Fix: Add note about drafts and posts in context of collections_dir to Fix: Add note about posts in context of collections_dir Jan 7, 2018

<h5>Be sure to move posts into custom collections directory</h5>
<p>If you specify a directory to store all your collections in the same place with <code>collections_dir: my_collections</code>, then you will need to move your <code>_posts</code> directory to <code>my_collections/_post</code>.</p>
</div>

This comment has been minimized.

@ashmaroli

ashmaroli Jan 7, 2018

Member

small typo..

- you will need to move your <code>_posts</code> directory to <code>my_collections/_post</code>.
+ you will need to move your <code>_posts</code> directory to <code>my_collections/_posts</code>.
@localheinz

This comment has been minimized.

Contributor

localheinz commented Jan 7, 2018

@ashmaroli

Already done!

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Jan 7, 2018

@lgp36018

This comment has been minimized.

lgp36018 commented Jan 7, 2018

Please unsubscribe the email for the above account.

@DirtyF

DirtyF approved these changes Jan 7, 2018

@DirtyF

This comment has been minimized.

Member

DirtyF commented Jan 7, 2018

Thanks @localheinz, this should save some headache to many people 😓

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit a8a6230 into jekyll:master Jan 7, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@localheinz

This comment has been minimized.

Contributor

localheinz commented Jan 7, 2018

Thank you, @ashmaroli, @DirtyF, and of course, @jekyllbot!

@localheinz localheinz deleted the localheinz:fix/documentation-collections branch Jan 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment